From: Greg KH <gregkh@linuxfoundation.org>
To: Gaosheng Cui <cuigaosheng1@huawei.com>
Cc: stable@vger.kernel.org, herbert@gondor.apana.org.au,
davem@davemloft.net, linux-crypto@vger.kernel.org
Subject: Re: [PATCH 5.10 1/4] crypto: api - Fix built-in testing dependency failures
Date: Sat, 15 Apr 2023 17:07:43 +0200 [thread overview]
Message-ID: <2023041513-sloppily-external-4c18@gregkh> (raw)
In-Reply-To: <20230415101158.1648486-2-cuigaosheng1@huawei.com>
On Sat, Apr 15, 2023 at 06:11:55PM +0800, Gaosheng Cui wrote:
> From: Herbert Xu <herbert@gondor.apana.org.au>
>
> When complex algorithms that depend on other algorithms are built
> into the kernel, the order of registration must be done such that
> the underlying algorithms are ready before the ones on top are
> registered. As otherwise they would fail during the self-test
> which is required during registration.
>
> In the past we have used subsystem initialisation ordering to
> guarantee this. The number of such precedence levels are limited
> and they may cause ripple effects in other subsystems.
>
> This patch solves this problem by delaying all self-tests during
> boot-up for built-in algorithms. They will be tested either when
> something else in the kernel requests for them, or when we have
> finished registering all built-in algorithms, whichever comes
> earlier.
>
> Reported-by: Vladis Dronov <vdronov@redhat.com>
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
> Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com>
> ---
> crypto/algapi.c | 73 +++++++++++++++++++++++++++++++++--------------
> crypto/api.c | 52 +++++++++++++++++++++++++++++----
> crypto/internal.h | 10 +++++++
> 3 files changed, 108 insertions(+), 27 deletions(-)
What is the git commit id of this, and the other 3 patches, in Linus's
tree? That is required to have here, as you know.
thanks,
greg k-h
next prev parent reply other threads:[~2023-04-15 15:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-15 10:11 [PATCH 5.10 0/4] Fix built-in testing dependency failures Gaosheng Cui
2023-04-15 10:11 ` [PATCH 5.10 1/4] crypto: api - " Gaosheng Cui
2023-04-15 15:07 ` Greg KH [this message]
[not found] ` <3f6315cc-4684-2121-3556-0ace47c29b35@huawei.com>
2023-04-18 9:28 ` Greg KH
2023-04-18 13:51 ` cuigaosheng
2023-04-15 10:11 ` [PATCH 5.10 2/4] crypto: api - Do not create test larvals if manager is disabled Gaosheng Cui
2023-04-15 10:11 ` [PATCH 5.10 3/4] crypto: api - Export crypto_boot_test_finished Gaosheng Cui
2023-04-15 10:11 ` [PATCH 5.10 4/4] crypto: api - Fix boot-up crash when crypto manager is disabled Gaosheng Cui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023041513-sloppily-external-4c18@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=cuigaosheng1@huawei.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox