public inbox for linux-crypto@vger.kernel.org
 help / color / mirror / Atom feed
From: Eric Biggers <ebiggers@kernel.org>
To: Dongsoo Lee <letrhee@nsr.re.kr>
Cc: 'Herbert Xu' <herbert@gondor.apana.org.au>,
	linux-crypto@vger.kernel.org, davem@davemloft.net,
	linux-kernel@vger.kernel.org, letrhee@gmail.com
Subject: Re: [PATCH v2 0/2] crypto: LEA block cipher implementation
Date: Fri, 2 Jun 2023 14:39:46 -0700	[thread overview]
Message-ID: <20230602213946.GD628@quark.localdomain> (raw)
In-Reply-To: <008d01d99518$33db63f0$9b922bd0$@nsr.re.kr>

On Fri, Jun 02, 2023 at 03:05:16PM +0900, Dongsoo Lee wrote:
> Additionally, we are exploring the possibility of using `blk-crypto` for
> encryption. Currently, the ciphers available for `blk-crypto` are
> AES-256-XTS, AES-128-CBC-ESSIV, Adiantum, and SM4-XTS. We would like to add
> LEA-256-XTS to these.
> 
> ( https://github.com/torvalds/linux/blob/master/block/blk-crypto.c#L21 )
> 
> Instead of disk encryption, it is also possible to use `fscrypt` to encrypt
> the file system for data-at-rest environments. `fscrypt` currently supports
> AES-256-XTS, AES-256-CTS-CBC, AES-128-CBC-ESSIV, AES-128-CTS-CBC, SM4-XTS,
> SM4-CTS-CBC, Adiantum, and AES-256-HCTR2.
> 
> ( https://github.com/torvalds/linux/blob/master/fs/crypto/keysetup.c#L16 )
> 

Currently the only user of blk-crypto is fscrypt.  So the above two paragraphs
are really talking about the same thing.

I haven't seen any patch that proposes adding LEA support to fscrypt.  Also, I'm
not sure that the information you've provided so far is sufficient motivation
for adding it to fscrypt.  I did recently allow another national pride cipher,
SM4, to be added to fscrypt, but that was only because a user said they were
being *required* to use SM4.  It's not clear that's the case for LEA.

- Eric

  reply	other threads:[~2023-06-02 21:39 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-25 12:12 [PATCH v2 0/2] crypto: LEA block cipher implementation Dongsoo Lee
2023-05-25 12:13 ` [PATCH v2 1/2] " Dongsoo Lee
2023-05-25 12:13 ` [PATCH v2 2/2] crypto: add LEA testmgr tests Dongsoo Lee
2023-06-01 10:38 ` [PATCH v2 0/2] crypto: LEA block cipher implementation Herbert Xu
2023-06-02  6:05   ` Dongsoo Lee
2023-06-02 21:39     ` Eric Biggers [this message]
2023-06-09 11:57       ` Dongsoo Lee
2023-06-10  2:14         ` Eric Biggers
2023-06-16  8:08           ` Dongsoo Lee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230602213946.GD628@quark.localdomain \
    --to=ebiggers@kernel.org \
    --cc=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=letrhee@gmail.com \
    --cc=letrhee@nsr.re.kr \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox