Re: [EXTERNAL] Re: [PATCH v2 3/6] dt-bindings: crypto: Add Texas Instruments MCRC64

Kamlesh Gurudasani
2024-05-27T08:26:08Z

Conor Dooley <conor@kernel.org> writes:

> On Fri, Aug 11, 2023 at 04:34:33PM +0100, Conor Dooley wrote:
>> On Fri, Aug 11, 2023 at 12:58:50AM +0530, Kamlesh Gurudasani wrote:
>> > Add binding for Texas Instruments MCRC64
>> >
>> > MCRC64 engine calculates 64-bit cyclic redundancy checks (CRC)
>> > according to the ISO 3309 standard.
>> >
>> > The ISO 3309 64-bit CRC model parameters are as follows:
>> > Generator Polynomial: x^64 + x^4 + x^3 + x + 1
>> > Polynomial Value: 0x000000000000001B
>> > Initial value: 0x0000000000000000
>> > Reflected Input: False
>> > Reflected Output: False
>> > Xor Final: 0x0000000000000000
>> >
>> > Signed-off-by: Kamlesh Gurudasani <kamlesh@ti.com>
>> > ---
>> > Documentation/devicetree/bindings/crypto/ti,mcrc64.yaml | 47 +++++++++++++++++++++++++++++++++++++++++++++++
>> > MAINTAINERS | 5 +++++
>> > 2 files changed, 52 insertions(+)
>> >
>> > diff --git a/Documentation/devicetree/bindings/crypto/ti,mcrc64.yaml b/Documentation/devicetree/bindings/crypto/ti,mcrc64.yaml
>> > new file mode 100644
>> > index 000000000000..38bc7efebd68
>> > --- /dev/null
>> > +++ b/Documentation/devicetree/bindings/crypto/ti,mcrc64.yaml
>> > @@ -0,0 +1,47 @@
>> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> > +%YAML 1.2
>> > +---
>> > +$id: http://devicetree.org/schemas/crypto/ti,mcrc64.yaml#
>> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> > +
>> > +title: Texas Instruments MCRC64
>> > +
>> > +description: The MCRC64 engine calculates 64-bit cyclic redundancy checks
>>
>> A newline after "description" please.
>>
>> > + (CRC) according to the ISO 3309 standard.
>> > +
>> > +maintainers:
>> > + - Kamlesh Gurudasani <kamlesh@ti.com>
>> > +
>> > +properties:
>> > + compatible:
>> > + const: ti,am62-mcrc64
>>
>> Is the am62 an SoC or a family of SoCs? I googled a wee bit for am62 &
>> there seems to be an am625 and an am623?
>
> Or is it an am62p5, in which case the compatible should contain
> ti,am62p5 I suppose. Sorry for my confusion here, its not really clear
> me too since I've been seeing many different-but-similar product names
> the last few days.
>
> Thanks,
> Conor.
>
Hi Conor,

Thanks for the review.

am62 is family of SOCs.

All devices under this family, like am623/5/p5 and etc, have MCRC64.

I have kept the naming convention similar to SA2UL/SA3UL[0].

[0] https://elixir.bootlin.com/linux/latest/source/Documentation/devicetree/bindings/crypto/ti,sa2ul.yaml#L18

Kamlesh

>>
>> Otherwise, this looks good to me.
>>
>> > +
>> > + reg:
>> > + maxItems: 1
>> > +
>> > + clocks:
>> > + maxItems: 1
>> > +
>> > + power-domains:
>> > + maxItems: 1
>> > +
>> > +required:
>> > + - compatible
>> > + - reg
>> > + - clocks
>> > + - power-domains
>> > +
>> > +additionalProperties: false
>> > +
>> > +examples:
>> > + - |
>> > + #include <dt-bindings/soc/ti,sci_pm_domain.h>
>> > +
>> > + crc@30300000 {
>> > + compatible = "ti,am62-mcrc64";
>> > + reg = <0x30300000 0x1000>;
>> > + clocks = <&k3_clks 116 0>;
>> > + power-domains = <&k3_pds 116 TI_SCI_PD_EXCLUSIVE>;
>> > + };
>> > +
>> > +...
>> > diff --git a/MAINTAINERS b/MAINTAINERS
>> > index 02a3192195af..66b51f43d196 100644
>> > --- a/MAINTAINERS
>> > +++ b/MAINTAINERS
>> > @@ -21481,6 +21481,11 @@ S: Maintained
>> > F: Documentation/devicetree/bindings/iio/adc/ti,lmp92064.yaml
>> > F: drivers/iio/adc/ti-lmp92064.c
>> >
>> > +TI MEMORY CYCLIC REDUNDANCY CHECK (MCRC64) DRIVER
>> > +M: Kamlesh Gurudasani <kamlesh@ti.com>
>> > +S: Maintained
>> > +F: Documentation/devicetree/bindings/crypto/ti,mcrc64.yaml
>> > +
>> > TI PCM3060 ASoC CODEC DRIVER
>> > M: Kirill Marinushkin <kmarinushkin@birdec.com>
>> > L: alsa-devel@alsa-project.org (moderated for non-subscribers)
>> >
>> > --
>> > 2.34.1
>> >