Re: [PATCH v2 6/6] arm64: defconfig: enable TI MCRC64 module

Nishanth Menon
2023-08-10T20:25:24Z

On 00:58-20230811, Kamlesh Gurudasani wrote:
> K3 devices include MCRC64 engine for crc64 calculation.
> Enable module to be built for K3 devices.
>
> Also enable algif_hash module, which is needed to access MCRC64 module
> from userspace.
>
> Signed-off-by: Kamlesh Gurudasani <kamlesh@ti.com>
> ---

There are few things to improve in this series, but we can discuss this
as part of defconfig merge

See thread: https://lore.kernel.org/linux-arm-kernel/ae2ad056-96de-41b7-8df4-1d9c0f5c469b@app.fastmail.com/
for additional info.

K3 devices is too broad, you want to specify specific boards that will
benefit out of this.

I suggest to keep this as "DONOTMERGE" to indicate this should'nt go via
subsystem maintainer tree (most maintainers are aware of it, but
explicitly calling it out helps keep things sane)

> arch/arm64/configs/defconfig | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> index bf13d5c46578..4d555a125315 100644
> --- a/arch/arm64/configs/defconfig
> +++ b/arch/arm64/configs/defconfig
> @@ -1535,6 +1535,7 @@ CONFIG_CRYPTO_TEST=m
> CONFIG_CRYPTO_ECHAINIV=y
> CONFIG_CRYPTO_MICHAEL_MIC=m
> CONFIG_CRYPTO_ANSI_CPRNG=y
> +CONFIG_CRYPTO_USER_API_HASH=m
> CONFIG_CRYPTO_USER_API_RNG=m
> CONFIG_CRYPTO_CHACHA20_NEON=m
> CONFIG_CRYPTO_GHASH_ARM64_CE=y
> @@ -1558,6 +1559,7 @@ CONFIG_CRYPTO_DEV_HISI_ZIP=m
> CONFIG_CRYPTO_DEV_HISI_HPRE=m
> CONFIG_CRYPTO_DEV_HISI_TRNG=m
> CONFIG_CRYPTO_DEV_SA2UL=m
> +CONFIG_CRYPTO_DEV_TI_MCRC64=m
> CONFIG_DMA_RESTRICTED_POOL=y
> CONFIG_CMA_SIZE_MBYTES=32
> CONFIG_PRINTK_TIME=y
>
> --
> 2.34.1
>

--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D