From: Martin Kaiser <martin@kaiser.cx>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: linux-crypto@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Martin Kaiser <martin@kaiser.cx>
Subject: [PATCH 2/3] hwrng: imx-rngc - read status register for error checks
Date: Tue, 22 Aug 2023 17:25:52 +0200 [thread overview]
Message-ID: <20230822152553.190858-3-martin@kaiser.cx> (raw)
In-Reply-To: <20230822152553.190858-1-martin@kaiser.cx>
The error bit in the status register of the imx-rngc is set for any kind
of error. Details about the error can be read from the bits in the error
status register.
In the imx_rngc_self_test, we just need the info if there was an error or
not. We can check the status register, there's no need to read the error
status register.
Signed-off-by: Martin Kaiser <martin@kaiser.cx>
---
drivers/char/hw_random/imx-rngc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/char/hw_random/imx-rngc.c b/drivers/char/hw_random/imx-rngc.c
index 85207535fd12..d2df468fd460 100644
--- a/drivers/char/hw_random/imx-rngc.c
+++ b/drivers/char/hw_random/imx-rngc.c
@@ -114,7 +114,7 @@ static int imx_rngc_self_test(struct imx_rngc *rngc)
if (ret < 0)
return ret;
- return readl(rngc->base + RNGC_ERROR) ? -EIO : 0;
+ return (status & RNGC_STATUS_ERROR) ? -EIO : 0;
}
static int imx_rngc_read(struct hwrng *rng, void *data, size_t max, bool wait)
--
2.39.2
next prev parent reply other threads:[~2023-08-22 15:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-22 15:25 [PATCH 0/3] hwrng: imx-rngc - use polling instead of interrupt Martin Kaiser
2023-08-22 15:25 ` [PATCH 1/3] hwrng: imx-rngc - use polling to detect end of self test Martin Kaiser
2023-08-23 5:23 ` Alexander Stein
2023-08-23 11:07 ` Martin Kaiser
2023-08-22 15:25 ` Martin Kaiser [this message]
2023-08-22 15:25 ` [PATCH 3/3] hwrng: imx-rngc - use polling to wait for end of seeding Martin Kaiser
2023-08-23 5:33 ` Alexander Stein
2023-08-23 11:16 ` Martin Kaiser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230822152553.190858-3-martin@kaiser.cx \
--to=martin@kaiser.cx \
--cc=herbert@gondor.apana.org.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox