Re: [PATCH] char: hw_random: xiphera-trng: removed unnneded platform_set_drvdata()

Alexandru Ardelean
2023-09-01T06:04:36Z

On Mon, Aug 28, 2023 at 1:29 PM Andrei Coardos <aboutphysycs@gmail.com> wrote:
>
> This function call was found to be unnecessary as there is no equivalent
> platform_get_drvdata() call to access the private data of the driver. Also,
> the private data is defined in this driver, so there is no risk of it being
> accessed outside of this driver file.
>
> Signed-off-by: Andrei Coardos <aboutphysycs@gmail.com>
> ---
> drivers/char/hw_random/xiphera-trng.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/char/hw_random/xiphera-trng.c b/drivers/char/hw_random/xiphera-trng.c
> index 2a9fea72b2e0..1fa4b70246f0 100644
> --- a/drivers/char/hw_random/xiphera-trng.c
> +++ b/drivers/char/hw_random/xiphera-trng.c
> @@ -122,8 +122,6 @@ static int xiphera_trng_probe(struct platform_device *pdev)
> return ret;
> }
>
> - platform_set_drvdata(pdev, trng);
> -
> return 0;

This entire block could become now:

return devm_hwrng_register(dev, &trng->rng);

> }
>
> --
> 2.34.1
>