From: Eric Biggers <ebiggers@kernel.org>
To: "Chang S. Bae" <chang.seok.bae@intel.com>
Cc: linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org,
herbert@gondor.apana.org.au, davem@davemloft.net, x86@kernel.org
Subject: Re: [PATCH 2/3] crypto: x86/aesni - Correct the data type in struct aesni_xts_ctx
Date: Mon, 25 Sep 2023 22:20:59 -0700 [thread overview]
Message-ID: <20230926052059.GC3118@sol.localdomain> (raw)
In-Reply-To: <20230925151752.162449-3-chang.seok.bae@intel.com>
On Mon, Sep 25, 2023 at 08:17:51AM -0700, Chang S. Bae wrote:
> Currently, every field in struct aesni_xts_ctx is defined as a byte
> array of the same size as struct crypto_aes_ctx. This data type
> is obscure and the choice lacks justification.
>
> To rectify this, update the field type in struct aesni_xts_ctx to
> match its actual structure.
>
> Suggested-by: Eric Biggers <ebiggers@kernel.org>
> Signed-off-by: Chang S. Bae <chang.seok.bae@intel.com>
> Cc: linux-crypto@vger.kernel.org
> Cc: x86@kernel.org
> Cc: linux-kernel@vger.kernel.org
> Link: https://lore.kernel.org/all/ZFWQ4sZEVu%2FLHq+Q@gmail.com/
Please put the "Link" directly after the Suggested-by to make it clear that the
link is for the suggestion. Thanks!
- Eric
next prev parent reply other threads:[~2023-09-26 5:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-25 15:17 [PATCH 0/3] crypto: x86/aesni - Improve XTS data type Chang S. Bae
2023-09-25 15:17 ` [PATCH 1/3] crypto: x86/aesni - Refactor the common address alignment code Chang S. Bae
2023-09-26 5:06 ` Eric Biggers
2023-09-25 15:17 ` [PATCH 2/3] crypto: x86/aesni - Correct the data type in struct aesni_xts_ctx Chang S. Bae
2023-09-26 5:20 ` Eric Biggers [this message]
2023-09-25 15:17 ` [PATCH 3/3] crypto: x86/aesni - Perform address alignment early for XTS mode Chang S. Bae
2023-09-28 7:25 ` [PATCH v2 0/3] crypto: x86/aesni - Improve XTS data type Chang S. Bae
2023-09-28 7:25 ` [PATCH v2 1/3] crypto: x86/aesni - Refactor the common address alignment code Chang S. Bae
2023-09-28 7:25 ` [PATCH v2 2/3] crypto: x86/aesni - Correct the data type in struct aesni_xts_ctx Chang S. Bae
2023-09-28 7:25 ` [PATCH v2 3/3] crypto: x86/aesni - Perform address alignment early for XTS mode Chang S. Bae
2023-10-05 10:25 ` [PATCH v2 0/3] crypto: x86/aesni - Improve XTS data type Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230926052059.GC3118@sol.localdomain \
--to=ebiggers@kernel.org \
--cc=chang.seok.bae@intel.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).