From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D880CD68EE for ; Tue, 10 Oct 2023 06:15:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1442180AbjJJGPq (ORCPT ); Tue, 10 Oct 2023 02:15:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45710 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1442156AbjJJGPp (ORCPT ); Tue, 10 Oct 2023 02:15:45 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CAAC997; Mon, 9 Oct 2023 23:15:43 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8FFFDC433C8; Tue, 10 Oct 2023 06:15:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1696918543; bh=wY8QJkm+jocEeUpbq07zihxLMe27HPMooctLb8gtMAs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JWDN21mJ9Z8E6RBWQSwNWfPjoNta/kvTTopqAQAUKPlYbHjSKbVZIBEvBi7qP3YeL yH7t8Wo+Ylsa+5+lhUVhorqFdYvjb8qAyx1c9MN1h8Dye+aKfLpNQswtI6d8x0M5K1 MJO1iForDWmtCxJQJyElkm25bgEXzEPHJII+D9ps= Date: Tue, 10 Oct 2023 08:15:40 +0200 From: Greg Kroah-Hartman To: Alexander Graf Cc: linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, Arnd Bergmann , Herbert Xu , Olivia Mackall , Petre Eftime , Erdem Meydanlli , Benjamin Herrenschmidt , David Woodhouse , "Michael S . Tsirkin" , Jason Wang , Xuan Zhuo , Kyunghwan Kwon Subject: Re: [PATCH v4 2/2] misc: Add Nitro Secure Module driver Message-ID: <2023101010-margarita-whomever-d4a2@gregkh> References: <20231009212053.2007-1-graf@amazon.com> <20231009212053.2007-3-graf@amazon.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231009212053.2007-3-graf@amazon.com> Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Mon, Oct 09, 2023 at 09:20:53PM +0000, Alexander Graf wrote: > When running Linux inside a Nitro Enclave, the hypervisor provides a > special virtio device called "NSM". This device has 3 main functions: > > 1) Provide attestation reports > 2) Modify PCR state > 3) Provide entropy > > This patch adds a driver for NSM that exposes a /dev/nsm device node which > user space can issue ioctls on to request attestation documents, influence > PCR states, read entropy and enumerate status of the device. In addition, > the driver implements a hwrng backend and exposes some of the NSM device > metadata as sysfs entries. > > Originally-by: Petre Eftime > Signed-off-by: Alexander Graf > > --- > > v1 -> v2: > > - Remove boilerplate > - Add uapi header > > v2 -> v3: > > - Move globals to device struct > - Add compat handling > - Simplify some naming > - Remove debug prints > - Use module_virtio_driver > - Drop use of uio.h > > v3 -> v4: > > - Merge hwrng into the misc driver > - Add dependency on CBOR library > - Add internal and ioctl logic for all current NSM actions > - Use in-struct arrays instead of kvecs > - Add sysfs entries for NSM metadata You forgot Documentation/ABI/ entries for your new sysfs files so we can see what exactly they are and if they are sane. thanks, greg k-h