Re: [PATCH v4 10/12] RISC-V: crypto: add Zvkned accelerated AES encryption implementation

Jerry Shih
2023-09-11T21:56:30Z

On Jul 21, 2023, at 13:40, Eric Biggers <ebiggers@kernel.org> wrote:

> I'm looking forward to having direct support for these AES modes, especially the
> modes needed for storage encryption: XTS, and CBC or CTS! None of these AES
> modes is actually implemented in this patch yet, though, so they can't be
> claimed in the kconfig help text yet. This patch is just a starting point, as
> it just adds support for the bare AES block cipher ("aes" in the crypto API).
>
> (BTW, I'm much more interested in, say, AES-XTS support than SM4 support, which
> this patchset does include. SM4 is a "national pride cipher" which is somewhat
> of a niche thing. I suppose there are already people pushing it for RISC-V
> though, as they are everywhere else, so that's to be expected...)
>

We have further optimization for RISC-V platform in OpenSSL PR[1]. It will include
AES with CBC, CTR, and XTS mode. Comparing to the generic AES implementation,
the specialized AES-XTS one have about 3X performance improvement using
OpenSSL benchmark tool. If OpenSSL accepts that PR, we will create the
corresponding patch for Linux kernel.

[1]
https://github.com/openssl/openssl/pull/21923

-Jerry