From: Tom Zanussi <tom.zanussi@linux.intel.com>
To: herbert@gondor.apana.org.au, davem@davemloft.net, fenghua.yu@intel.com
Cc: dave.jiang@intel.com, tony.luck@intel.com,
jacob.jun.pan@intel.com, christophe.jaillet@wanadoo.fr,
linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org,
dmaengine@vger.kernel.org
Subject: [PATCH 1/2] crypto: iaa - Change desc->priv to 0
Date: Mon, 18 Dec 2023 14:47:14 -0600 [thread overview]
Message-ID: <20231218204715.220299-2-tom.zanussi@linux.intel.com> (raw)
In-Reply-To: <20231218204715.220299-1-tom.zanussi@linux.intel.com>
In order for shared workqeues to work properly, desc->priv should be
set to 0 rather than 1. The need for this is described in commit
f5ccf55e1028 (dmaengine/idxd: Re-enable kernel workqueue under DMA
API), so we need to make IAA consistent with IOMMU settings, otherwise
we get:
[ 141.948389] IOMMU: dmar15: Page request in Privilege Mode
[ 141.948394] dmar15: Invalid page request: 2000026a100101 ffffb167
Dedicated workqueues ignore this field and are unaffected.
Signed-off-by: Tom Zanussi <tom.zanussi@linux.intel.com>
---
drivers/crypto/intel/iaa/iaa_crypto_main.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/crypto/intel/iaa/iaa_crypto_main.c b/drivers/crypto/intel/iaa/iaa_crypto_main.c
index eafa2dd7a5bb..5093361b0107 100644
--- a/drivers/crypto/intel/iaa/iaa_crypto_main.c
+++ b/drivers/crypto/intel/iaa/iaa_crypto_main.c
@@ -484,7 +484,7 @@ static int decompress_header(struct iaa_device_compression_mode *device_mode,
desc->decompr_flags = mode->gen_decomp_table_flags;
- desc->priv = 1;
+ desc->priv = 0;
desc->completion_addr = idxd_desc->compl_dma;
@@ -1255,7 +1255,7 @@ static int iaa_compress(struct crypto_tfm *tfm, struct acomp_req *req,
IDXD_OP_FLAG_RD_SRC2_AECS | IDXD_OP_FLAG_CC;
desc->opcode = IAX_OPCODE_COMPRESS;
desc->compr_flags = IAA_COMP_FLAGS;
- desc->priv = 1;
+ desc->priv = 0;
desc->src1_addr = (u64)src_addr;
desc->src1_size = slen;
@@ -1409,7 +1409,7 @@ static int iaa_compress_verify(struct crypto_tfm *tfm, struct acomp_req *req,
desc->flags = IDXD_OP_FLAG_CRAV | IDXD_OP_FLAG_RCR | IDXD_OP_FLAG_CC;
desc->opcode = IAX_OPCODE_DECOMPRESS;
desc->decompr_flags = IAA_DECOMP_FLAGS | IAA_DECOMP_SUPPRESS_OUTPUT;
- desc->priv = 1;
+ desc->priv = 0;
desc->src1_addr = (u64)dst_addr;
desc->src1_size = *dlen;
@@ -1495,7 +1495,7 @@ static int iaa_decompress(struct crypto_tfm *tfm, struct acomp_req *req,
desc->opcode = IAX_OPCODE_DECOMPRESS;
desc->max_dst_size = PAGE_SIZE;
desc->decompr_flags = IAA_DECOMP_FLAGS;
- desc->priv = 1;
+ desc->priv = 0;
desc->src1_addr = (u64)src_addr;
desc->dst_addr = (u64)dst_addr;
--
2.34.1
next prev parent reply other threads:[~2023-12-18 20:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-18 20:47 [PATCH 0/2] crypto: Intel Analytics Accelerator (IAA) updates Tom Zanussi
2023-12-18 20:47 ` Tom Zanussi [this message]
2023-12-18 21:47 ` [PATCH 1/2] crypto: iaa - Change desc->priv to 0 Dave Jiang
2023-12-18 21:55 ` Fenghua Yu
2023-12-18 20:47 ` [PATCH 2/2] crypto: iaa - Remove unneeded newline in update_max_adecomp_delay_ns() Tom Zanussi
2023-12-18 21:48 ` Dave Jiang
2023-12-18 21:55 ` Fenghua Yu
2023-12-29 3:28 ` [PATCH 0/2] crypto: Intel Analytics Accelerator (IAA) updates Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231218204715.220299-2-tom.zanussi@linux.intel.com \
--to=tom.zanussi@linux.intel.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=dave.jiang@intel.com \
--cc=davem@davemloft.net \
--cc=dmaengine@vger.kernel.org \
--cc=fenghua.yu@intel.com \
--cc=herbert@gondor.apana.org.au \
--cc=jacob.jun.pan@intel.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox