From: Eric Biggers <ebiggers@kernel.org>
To: Jerry Shih <jerry.shih@sifive.com>
Cc: linux-crypto@vger.kernel.org, linux-riscv@lists.infradead.org,
Christoph Muellner <christoph.muellner@vrull.eu>
Subject: Re: [PATCH] crypto: riscv - use real assembler for vector crypto extensions
Date: Thu, 21 Dec 2023 22:52:27 -0600 [thread overview]
Message-ID: <20231222045227.GA52600@quark.localdomain> (raw)
In-Reply-To: <3C51992F-B8F8-4023-81EE-3C95102B072A@sifive.com>
On Fri, Dec 22, 2023 at 10:15:04AM +0800, Jerry Shih wrote:
> On Dec 20, 2023, at 14:56, Eric Biggers <ebiggers@kernel.org> wrote:
> > From: Eric Biggers <ebiggers@google.com>
> >
> > LLVM main and binutils master now both fully support v1.0 of the RISC-V
> > vector crypto extensions. Therefore, delete riscv.pm and use the real
> > assembler mnemonics for the vector crypto instructions.
> >
> > Signed-off-by: Eric Biggers <ebiggers@google.com>
> > ---
> >
> > Hi Jerry, this patch applies to your v3 patchset
> > (https://lore.kernel.org/linux-crypto/20231205092801.1335-1-jerry.shih@sifive.com).
> > Can you consider folding it into your patchset? Thanks!
>
> Thank you for the vector crypto asm mnemonics works.
> Do you mean that fold this patch or append this one as the separated
> commit into my next v4 patchset?
Just fold the changes into your individual patches, please. Thanks!
> > config TOOLCHAIN_HAS_ZBB
> > bool
> > default y
> > depends on !64BIT || $(cc-option,-mabi=lp64 -march=rv64ima_zbb)
> > depends on !32BIT || $(cc-option,-mabi=ilp32 -march=rv32ima_zbb)
> > depends on LLD_VERSION >= 150000 || LD_VERSION >= 23900
> > depends on AS_HAS_OPTION_ARCH
> >
> > +# This option indicates that the toolchain supports all v1.0 vector crypto
> > +# extensions, including Zvk*, Zvbb, and Zvbc. LLVM added all of these at once.
> > +# binutils added all except Zvkb, then added Zvkb. So we just check for Zvkb.
> > +config TOOLCHAIN_HAS_ZVK
> > + def_bool $(as-instr, .option arch$(comma) +zvkb)
> > +
>
> Could we rename to other terms like
> `TOOLCHAIN_HAS_VECTOR_CRYPTO/TOOLCHAIN_HAS_V_CRYPTO `?
> Some ciphers don't use `ZVK*` extensions.
Yes, TOOLCHAIN_HAS_VECTOR_CRYPTO sounds good.
- Eric
prev parent reply other threads:[~2023-12-22 4:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-20 6:56 [PATCH] crypto: riscv - use real assembler for vector crypto extensions Eric Biggers
2023-12-20 7:48 ` Ard Biesheuvel
2023-12-20 7:52 ` Christoph Müllner
2023-12-20 15:31 ` Eric Biggers
2023-12-22 2:05 ` Jerry Shih
2023-12-22 2:15 ` Jerry Shih
2023-12-22 4:52 ` Eric Biggers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231222045227.GA52600@quark.localdomain \
--to=ebiggers@kernel.org \
--cc=christoph.muellner@vrull.eu \
--cc=jerry.shih@sifive.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox