Re: [PATCH v2] hwrng: add Zhaoxin rng driver base on rep_xstore instruction

Herbert Xu
2023-11-17T10:35:42Z

On Wed, Nov 08, 2023 at 03:34:54PM +0800, LeoLiu-oc wrote:
> From: LeoLiuoc <LeoLiu-oc@zhaoxin.com>
>
> Add support for Zhaoxin hardware random number generator.
> This driver base on rep_xstore instruction and uses the same
> X86_FEATURE_XSTORE as via-rng driver. Therefore, modify the x86_cpu_id
> array in the via-rng driver, so that the corresponding driver can be
> correctly loader on respective platforms.
>
> ---
>
> v1 -> v2:
> 1. Fix assembler code errors
> 2. Remove redundant CPU model check codes
>
> Signed-off-by: LeoLiuoc <LeoLiu-oc@zhaoxin.com>
> ---
> drivers/char/hw_random/Kconfig | 13 ++++
> drivers/char/hw_random/Makefile | 1 +
> drivers/char/hw_random/via-rng.c | 23 +++----
> drivers/char/hw_random/zhaoxin-rng.c | 95 ++++++++++++++++++++++++++++
> 4 files changed, 119 insertions(+), 13 deletions(-)
> create mode 100644 drivers/char/hw_random/zhaoxin-rng.c

Please cc x86@vger.kernel.org as the same comments to the other
zhaoxin driver seems to be applicable here.

Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt