Re: [PATCH v2] Enable config for sm3, sm4, polyval, xctr cipher test as built in module.

Eric Biggers
2024-02-05T20:19:23Z

On Mon, Feb 05, 2024 at 12:29:33PM +0100, Kshitiz Varshney wrote:
> Issue:-
> Multiple crypto tests like sm3, sm4 xctr and polyval failing.
>
> skcipher: failed to allocate transform for xctr(aes): -2
> alg: self-tests for xctr(aes) using xctr(aes) failed (rc=-2)
> alg: self-tests for sm3 using sm3 failed (rc=-2)
> tcrypt: failed to load transform for sm3: -2
> alg: hash: failed to allocate transform for polyval: -2
> alg: self-tests for polyval using polyval failed (rc=-2)
>
> Resolution:-
> Enabling CONFIG_CRYPTO_SM3_GENERIC, CONFIG_CRYPTO_SM4_GENERIC,
> CONFIG_CRYPTO_HCTR2, CONFIG_CRYPTO_ARIA as module enables support of
> sm3, sm4, aria, polyval & xctr.
>
> Signed-off-by: Kshitiz Varshney <kshitiz.varshney@nxp.com>

This looks like an issue in tcrypt. When algorithms are unavailable it should
consider the corresponding test cases to be skipped, not failed.

> arch/arm/configs/imx_v6_v7_defconfig | 4 ++++

There should be no need to enable every crypto algorithm in every defconfig
file. Can you consider fixing the underlying issue instead of doing that?

- Eric