linux-crypto.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lukas Wunner <lukas@wunner.de>
To: Jarkko Sakkinen <jarkko@kernel.org>
Cc: David Howells <dhowells@redhat.com>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	"David S. Miller" <davem@davemloft.net>,
	Jonathan Cameron <Jonathan.Cameron@huawei.com>,
	keyrings@vger.kernel.org, linux-crypto@vger.kernel.org,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Dan Williams <dan.j.williams@intel.com>,
	Ard Biesheuvel <ardb@kernel.org>
Subject: Re: [PATCH] X.509: Introduce scope-based x509_certificate allocation
Date: Mon, 12 Feb 2024 12:35:54 +0100	[thread overview]
Message-ID: <20240212113554.GA15065@wunner.de> (raw)
In-Reply-To: <CYLHFLJROQG2.SCLJMME8WBN8@suppilovahvero>

On Mon, Jan 22, 2024 at 09:29:33PM +0200, Jarkko Sakkinen wrote:
> On Sun Jan 21, 2024 at 7:50 PM EET, Lukas Wunner wrote:
> > Jonathan suggests adding cleanup.h support for x509_certificate structs:
> > https://lore.kernel.org/all/20231003153937.000034ca@Huawei.com/
[...]
> > x509_certificate allocation currently makes sense.  Another user will
> > be introduced with the upcoming SPDM library (Security Protocol and
> > Data Model) for PCI device authentication.
> 
> What is it and why we care about it here?

SPDM is a generic protocol for device authentication and measurement
retrieval which has been adopted by the PCISIG and other consortiums.
Jonathan's above-linked suggestion to add cleanup.h support for
x509_certificate structs was in reply to a patch set I submitted
to add SPDM and PCI device authentication support to the kernel.
The cover letter of that patch set is available here:

https://lore.kernel.org/all/cover.1695921656.git.lukas@wunner.de/

I am working on a v2 of that patch set which will take advantage of
cleanup.h support for x509_certificate structs.  So the present patch
is a prerequisite for it.

I don't think it's opportune or necessary to mention the patch set
more verbosely in the commit message here, I just want to point out
that the two functions converted by the patch will not be the only
ones and that there's another use case coming up.

I've just respun the patch and have amended the commit message with
all the other feedback you gave.

Thanks,

Lukas

  reply	other threads:[~2024-02-12 11:35 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-21 17:50 [PATCH] X.509: Introduce scope-based x509_certificate allocation Lukas Wunner
2024-01-22 19:29 ` Jarkko Sakkinen
2024-02-12 11:35   ` Lukas Wunner [this message]
2024-01-26  5:37 ` Herbert Xu
2024-01-28 13:32   ` Andy Shevchenko
2024-01-29  2:32     ` Herbert Xu
2024-02-12 11:39   ` Lukas Wunner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240212113554.GA15065@wunner.de \
    --to=lukas@wunner.de \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=ardb@kernel.org \
    --cc=dan.j.williams@intel.com \
    --cc=davem@davemloft.net \
    --cc=dhowells@redhat.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=jarkko@kernel.org \
    --cc=keyrings@vger.kernel.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).