Re: [PATCH v12 12/29] KVM: SEV: Add KVM_SEV_SNP_LAUNCH_FINISH command

Paolo Bonzini
2024-03-30T20:41:38Z

On 3/29/24 23:58, Michael Roth wrote:
>
> + /* Handle boot vCPU first to ensure consistent measurement of initial state. */
> + if (!boot_vcpu_handled && vcpu->vcpu_id != 0)
> + continue;
> +
> + if (boot_vcpu_handled && vcpu->vcpu_id == 0)
> + continue;

Why was this not necessary for KVM_SEV_LAUNCH_UPDATE_VMSA? Do we need
it now?

> +See SEV-SNP specification [snp-fw-abi]_ for SNP_LAUNCH_FINISH further details
> +on launch finish input parameters.

See SNP_LAUNCH_FINISH in the SEV-SNP specification [snp-fw-abi]_ for
further details on the input parameters in ``struct
kvm_sev_snp_launch_finish``.

Paolo