public inbox for linux-crypto@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Chenghai Huang <huangchenghai2@huawei.com>
Cc: zhangfei.gao@linaro.org, wangzhou1@hisilicon.com,
	linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org,
	fanghao11@huawei.com, shenyang39@huawei.com,
	liulongfang@huawei.com, qianweili@huawei.com
Subject: Re: [PATCH] misc: uacce - add the null check for the input pointer and its pointer members
Date: Fri, 29 Mar 2024 07:34:50 +0100	[thread overview]
Message-ID: <2024032946-supernova-unstaffed-63ec@gregkh> (raw)
In-Reply-To: <20240329062655.3055646-1-huangchenghai2@huawei.com>

On Fri, Mar 29, 2024 at 02:26:55PM +0800, Chenghai Huang wrote:
> The uacce_alloc() is the member of the EXPORT_SYMBOL_GPL. Therefore, null
> pointer verification is added on the pointer type input parameter and its
> pointer members.

I do not understand, why does the export type matter?  Just fix any
callers to use this properly and send proper parameters.  What in-tree
caller needs this?

thanks,

greg k-h

  reply	other threads:[~2024-03-29  6:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-29  6:26 [PATCH] misc: uacce - add the null check for the input pointer and its pointer members Chenghai Huang
2024-03-29  6:34 ` Greg KH [this message]
     [not found]   ` <d6890b98-2f75-4077-b7bc-e995e9901574@huawei.com>
2024-03-30  7:01     ` Greg KH
2024-03-30  7:10       ` huangchenghai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2024032946-supernova-unstaffed-63ec@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=fanghao11@huawei.com \
    --cc=huangchenghai2@huawei.com \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=liulongfang@huawei.com \
    --cc=qianweili@huawei.com \
    --cc=shenyang39@huawei.com \
    --cc=wangzhou1@hisilicon.com \
    --cc=zhangfei.gao@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox