From: Sergey Senozhatsky <senozhatsky@chromium.org>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Sergey Senozhatsky <senozhatsky@chromium.org>,
Linux Crypto Mailing List <linux-crypto@vger.kernel.org>
Subject: Re: [PATCH 1/3] crypto: scomp - Add setparam interface
Date: Sat, 1 Jun 2024 09:24:15 +0900 [thread overview]
Message-ID: <20240601002415.GH8400@google.com> (raw)
In-Reply-To: <ZlmKX4dD1EcstVmN@gondor.apana.org.au>
On (24/05/31 16:29), Herbert Xu wrote:
> On Fri, May 31, 2024 at 03:34:44PM +0900, Sergey Senozhatsky wrote:
> >
> > So passing "raw" algorithm parameters to crypto_scomp_setparam(tfm) can be
> > suboptimal, depending on the compression driver. For instance, for zstd
> > (what is currently done in zram [1]) we pre-process "raw" parameters:
> > parse dictionary in order to get zstd_cdict and zstd_ddict which are then
> > shared by all tfm-s (as they access C/D dictionaries in read-only mode).
> > For zram/zswap doing this per-tfm would result in extra per-CPU
> > zstd_cdict/zstd_ddict allocations, which is a significant overhead.
>
> If they share the dictionary, why can't they just share the
> tfm directly? Or do you actually need to vary the other parameters
> while keeping the dictionary the same?
Is it possible to share a tfm? I thought that tfm-s carry some state
(compression workmem/scratch buffer) so one cannot do parallel compressions
on different CPUs using the same tfm.
next prev parent reply other threads:[~2024-06-01 0:24 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-20 11:04 [PATCH 0/3] crypto: acomp - Add interface to set parameters Herbert Xu
2024-05-20 11:04 ` [PATCH 1/3] crypto: scomp - Add setparam interface Herbert Xu
2024-05-31 5:47 ` Sergey Senozhatsky
2024-05-31 6:34 ` Sergey Senozhatsky
2024-05-31 8:29 ` Herbert Xu
2024-06-01 0:24 ` Sergey Senozhatsky [this message]
2024-06-01 3:54 ` Herbert Xu
2024-06-03 2:34 ` Sergey Senozhatsky
2024-06-03 8:28 ` Sergey Senozhatsky
2024-06-03 8:34 ` Herbert Xu
2024-06-04 5:09 ` Sergey Senozhatsky
2024-06-04 8:48 ` Herbert Xu
2024-05-31 8:30 ` Herbert Xu
2024-05-20 11:04 ` [PATCH 2/3] crypto: acomp " Herbert Xu
2025-05-06 16:01 ` Cabiddu, Giovanni
2025-05-07 2:20 ` Herbert Xu
2025-05-07 13:16 ` Cabiddu, Giovanni
2025-05-08 5:01 ` Sergey Senozhatsky
2025-05-07 17:16 ` Eric Biggers
2025-05-08 5:42 ` Sergey Senozhatsky
2025-05-08 19:21 ` Kanchana P Sridhar
2024-05-20 11:04 ` [PATCH 3/3] crypto: acomp - Add comp_params helpers Herbert Xu
2024-05-31 5:49 ` Sergey Senozhatsky
2024-05-31 8:32 ` Herbert Xu
2024-05-31 5:07 ` [PATCH 0/3] crypto: acomp - Add interface to set parameters Herbert Xu
2024-05-31 5:12 ` Sergey Senozhatsky
2024-05-31 5:18 ` Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240601002415.GH8400@google.com \
--to=senozhatsky@chromium.org \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).