From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: linux-crypto@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Biggers <ebiggers@google.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
Thomas Gleixner <tglx@linutronix.de>
Subject: [PATCH] crypto: x86/aes-gcm: Disable FPU around skcipher_walk_done().
Date: Fri, 2 Aug 2024 12:23:33 +0200 [thread overview]
Message-ID: <20240802102333.itejxOsJ@linutronix.de> (raw)
kernel_fpu_begin() disables preemption. gcm_crypt() has a
skcipher_walk_done() invocation within a preempt disabled section.
skcipher_walk_done() can invoke kfree() which requires sleeping locks on
PREEMPT_RT and must not be invoked with disabled preemption.
Keep FPU access enabled while skcipher_walk_done() is invoked.
Fixes: b06affb1cb580 ("crypto: x86/aes-gcm - add VAES and AVX512 / AVX10 optimized AES-GCM")
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
---
arch/x86/crypto/aesni-intel_glue.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/x86/crypto/aesni-intel_glue.c b/arch/x86/crypto/aesni-intel_glue.c
index cd37de5ec4046..be92e4c3f9c7f 100644
--- a/arch/x86/crypto/aesni-intel_glue.c
+++ b/arch/x86/crypto/aesni-intel_glue.c
@@ -1403,7 +1403,9 @@ gcm_crypt(struct aead_request *req, int flags)
aes_gcm_update(key, le_ctr, ghash_acc,
walk.src.virt.addr, walk.dst.virt.addr,
nbytes, flags);
+ kernel_fpu_end();
err = skcipher_walk_done(&walk, 0);
+ kernel_fpu_begin();
/*
* The low word of the counter isn't used by the
* finalize, so there's no need to increment it here.
--
2.45.2
next reply other threads:[~2024-08-02 10:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-02 10:23 Sebastian Andrzej Siewior [this message]
2024-08-02 16:28 ` [PATCH] crypto: x86/aes-gcm: Disable FPU around skcipher_walk_done() Eric Biggers
2024-08-02 16:49 ` Eric Biggers
2024-08-05 9:02 ` Herbert Xu
2024-08-05 9:56 ` Sebastian Andrzej Siewior
2024-08-03 0:34 ` Herbert Xu
2024-08-05 8:21 ` Sebastian Andrzej Siewior
2024-08-05 8:41 ` Sebastian Andrzej Siewior
2024-08-05 17:38 ` Eric Biggers
2024-08-06 7:46 ` Sebastian Andrzej Siewior
2024-08-03 0:37 ` Herbert Xu
2024-08-05 9:34 ` Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240802102333.itejxOsJ@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=davem@davemloft.net \
--cc=ebiggers@google.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox