Linux cryptographic layer development
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Kamlesh Gurudasani <kamlesh@ti.com>
Cc: Steffen Klassert <steffen.klassert@secunet.com>,
	Daniel Jordan <daniel.m.jordan@oracle.com>,
	Waiman Long <longman@redhat.com>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	<linux-crypto@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] padata: Honor the caller's alignment in case of chunk_size 0
Date: Wed, 21 Aug 2024 15:41:36 -0700	[thread overview]
Message-ID: <20240821154136.a09fa0e80903aa9ae17d43bd@linux-foundation.org> (raw)
In-Reply-To: <20240822-max-v1-1-cb4bc5b1c101@ti.com>

On Thu, 22 Aug 2024 02:32:52 +0530 Kamlesh Gurudasani <kamlesh@ti.com> wrote:

> In the case where we are forcing the ps.chunk_size to be at least 1,
> we are ignoring the caller's alignment.
> 
> Move the forcing of ps.chunk_size to be at least 1 before rounding it
> up to caller's alignment, so that caller's alignment is honored.
> 
> While at it, use max() to force the ps.chunk_size to be at least 1 to
> improve readability.

Please (as always) describe the userspace-visible runtime effects of
this change.  This helps others to determine which kernel(s) should be
patched.  And it helps others decide whether this fix might address an
issue which they are encountering.



  reply	other threads:[~2024-08-21 22:41 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-21 21:02 [PATCH] padata: Honor the caller's alignment in case of chunk_size 0 Kamlesh Gurudasani
2024-08-21 22:41 ` Andrew Morton [this message]
2024-08-25 11:27   ` [EXTERNAL] " Kamlesh Gurudasani
2024-08-21 23:30 ` Waiman Long
2024-08-25 11:34   ` [EXTERNAL] " Kamlesh Gurudasani
2024-08-25 15:57     ` Waiman Long
2024-08-23  0:50 ` Daniel Jordan
2024-08-25 11:29   ` Kamlesh Gurudasani
2024-08-30 10:39 ` Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240821154136.a09fa0e80903aa9ae17d43bd@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=daniel.m.jordan@oracle.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=kamlesh@ti.com \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=longman@redhat.com \
    --cc=steffen.klassert@secunet.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox