public inbox for linux-crypto@vger.kernel.org
 help / color / mirror / Atom feed
From: "Ernesto A. Fernández" <ernesto.mnd.fernandez@gmail.com>
To: linux-crypto@vger.kernel.org,
	Herbert Xu <herbert@gondor.apana.org.au>,
	"David S. Miller" <davem@davemloft.net>,
	linux-arm-msm@vger.kernel.org
Cc: Om Prakash Singh <quic_omprsing@quicinc.com>
Subject: qcom-rng is broken for acpi
Date: Wed, 28 Aug 2024 15:40:19 -0300	[thread overview]
Message-ID: <20240828184019.GA21181@eaf> (raw)

Hi, I have a bug to report.

I'm getting a null pointer dereference inside qcom_rng_probe() when this
driver gets loaded. The problem comes from here:

  rng->of_data = (struct qcom_rng_of_data *)of_device_get_match_data(&pdev->dev);

because of_device_get_match_data() will just return null for acpi. It seems
that acpi was left behind by the changes in commit f29cd5bb64c2 ("crypto:
qcom-rng - Add hw_random interface support").

Thanks in advance, let me know if you need anything else.
Ernesto

             reply	other threads:[~2024-08-28 18:40 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-28 18:40 Ernesto A. Fernández [this message]
2024-08-28 19:03 ` qcom-rng is broken for acpi Trilok Soni
2024-08-28 20:13   ` Ernesto A. Fernández
2024-08-28 20:28     ` Ernesto A. Fernández
2024-08-29  1:25     ` Brian Masney
2024-08-29 14:55       ` Jeffrey Hugo
2024-09-06  0:14         ` Brian Masney
2024-09-16  5:07           ` Jeffrey Hugo
2024-09-16 17:42             ` Jeffrey Hugo
2024-09-16 19:40               ` Brian Masney
2024-09-17 21:24                 ` Jeffrey Hugo
2024-10-08 20:08                   ` Jeffrey Hugo
  -- strict thread matches above, loose matches on Subject: below --
2024-09-06 20:33 Sam Bingner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240828184019.GA21181@eaf \
    --to=ernesto.mnd.fernandez@gmail.com \
    --cc=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=quic_omprsing@quicinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox