[PATCH] async_xor: Remove unused 'async_xor_val'

[PATCH] async_xor: Remove unused 'async_xor_val'

[linux]

From: "Dr. David Alan Gilbert" <linux@treblig.org>

async_xor_val has been unused since commit
a7c224a820c3 ("md/raid5: convert to new xor compution interface")

Remove it.

Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
---
 crypto/async_tx/async_xor.c | 26 --------------------------
 include/linux/async_tx.h    |  5 -----
 2 files changed, 31 deletions(-)

diff --git a/crypto/async_tx/async_xor.c b/crypto/async_tx/async_xor.c
index 1a3855284091..2c499654a36c 100644
--- a/crypto/async_tx/async_xor.c
+++ b/crypto/async_tx/async_xor.c
@@ -389,32 +389,6 @@ async_xor_val_offs(struct page *dest, unsigned int offset,
 }
 EXPORT_SYMBOL_GPL(async_xor_val_offs);
 
-/**
- * async_xor_val - attempt a xor parity check with a dma engine.
- * @dest: destination page used if the xor is performed synchronously
- * @src_list: array of source pages
- * @offset: offset in pages to start transaction
- * @src_cnt: number of source pages
- * @len: length in bytes
- * @result: 0 if sum == 0 else non-zero
- * @submit: submission / completion modifiers
- *
- * honored flags: ASYNC_TX_ACK
- *
- * src_list note: if the dest is also a source it must be at index zero.
- * The contents of this array will be overwritten if a scribble region
- * is not specified.
- */
-struct dma_async_tx_descriptor *
-async_xor_val(struct page *dest, struct page **src_list, unsigned int offset,
-	      int src_cnt, size_t len, enum sum_check_flags *result,
-	      struct async_submit_ctl *submit)
-{
-	return async_xor_val_offs(dest, offset, src_list, NULL, src_cnt,
-			len, result, submit);
-}
-EXPORT_SYMBOL_GPL(async_xor_val);
-
 MODULE_AUTHOR("Intel Corporation");
 MODULE_DESCRIPTION("asynchronous xor/xor-zero-sum api");
 MODULE_LICENSE("GPL");
diff --git a/include/linux/async_tx.h b/include/linux/async_tx.h
index 5cc73d7e5b52..1ca9f9e05f4f 100644
--- a/include/linux/async_tx.h
+++ b/include/linux/async_tx.h
@@ -167,11 +167,6 @@ async_xor_offs(struct page *dest, unsigned int offset,
 		struct page **src_list, unsigned int *src_offset,
 		int src_cnt, size_t len, struct async_submit_ctl *submit);
 
-struct dma_async_tx_descriptor *
-async_xor_val(struct page *dest, struct page **src_list, unsigned int offset,
-	      int src_cnt, size_t len, enum sum_check_flags *result,
-	      struct async_submit_ctl *submit);
-
 struct dma_async_tx_descriptor *
 async_xor_val_offs(struct page *dest, unsigned int offset,
 		struct page **src_list, unsigned int *src_offset,
-- 
2.46.2

Re: [PATCH] async_xor: Remove unused 'async_xor_val'

[Dr. David Alan Gilbert]

* linux@treblig.org (linux@treblig.org) wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
> 
> async_xor_val has been unused since commit
> a7c224a820c3 ("md/raid5: convert to new xor compution interface")
> 
> Remove it.
> 
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>

Ping.

Thanks,

Dave

> ---
>  crypto/async_tx/async_xor.c | 26 --------------------------
>  include/linux/async_tx.h    |  5 -----
>  2 files changed, 31 deletions(-)
> 
> diff --git a/crypto/async_tx/async_xor.c b/crypto/async_tx/async_xor.c
> index 1a3855284091..2c499654a36c 100644
> --- a/crypto/async_tx/async_xor.c
> +++ b/crypto/async_tx/async_xor.c
> @@ -389,32 +389,6 @@ async_xor_val_offs(struct page *dest, unsigned int offset,
>  }
>  EXPORT_SYMBOL_GPL(async_xor_val_offs);
>  
> -/**
> - * async_xor_val - attempt a xor parity check with a dma engine.
> - * @dest: destination page used if the xor is performed synchronously
> - * @src_list: array of source pages
> - * @offset: offset in pages to start transaction
> - * @src_cnt: number of source pages
> - * @len: length in bytes
> - * @result: 0 if sum == 0 else non-zero
> - * @submit: submission / completion modifiers
> - *
> - * honored flags: ASYNC_TX_ACK
> - *
> - * src_list note: if the dest is also a source it must be at index zero.
> - * The contents of this array will be overwritten if a scribble region
> - * is not specified.
> - */
> -struct dma_async_tx_descriptor *
> -async_xor_val(struct page *dest, struct page **src_list, unsigned int offset,
> -	      int src_cnt, size_t len, enum sum_check_flags *result,
> -	      struct async_submit_ctl *submit)
> -{
> -	return async_xor_val_offs(dest, offset, src_list, NULL, src_cnt,
> -			len, result, submit);
> -}
> -EXPORT_SYMBOL_GPL(async_xor_val);
> -
>  MODULE_AUTHOR("Intel Corporation");
>  MODULE_DESCRIPTION("asynchronous xor/xor-zero-sum api");
>  MODULE_LICENSE("GPL");
> diff --git a/include/linux/async_tx.h b/include/linux/async_tx.h
> index 5cc73d7e5b52..1ca9f9e05f4f 100644
> --- a/include/linux/async_tx.h
> +++ b/include/linux/async_tx.h
> @@ -167,11 +167,6 @@ async_xor_offs(struct page *dest, unsigned int offset,
>  		struct page **src_list, unsigned int *src_offset,
>  		int src_cnt, size_t len, struct async_submit_ctl *submit);
>  
> -struct dma_async_tx_descriptor *
> -async_xor_val(struct page *dest, struct page **src_list, unsigned int offset,
> -	      int src_cnt, size_t len, enum sum_check_flags *result,
> -	      struct async_submit_ctl *submit);
> -
>  struct dma_async_tx_descriptor *
>  async_xor_val_offs(struct page *dest, unsigned int offset,
>  		struct page **src_list, unsigned int *src_offset,
> -- 
> 2.46.2
> 
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/

Re: [PATCH] async_xor: Remove unused 'async_xor_val'

[Herbert Xu]

On Sun, Sep 29, 2024 at 02:21:48PM +0100, linux@treblig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
> 
> async_xor_val has been unused since commit
> a7c224a820c3 ("md/raid5: convert to new xor compution interface")
> 
> Remove it.
> 
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> ---
>  crypto/async_tx/async_xor.c | 26 --------------------------
>  include/linux/async_tx.h    |  5 -----
>  2 files changed, 31 deletions(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH] async_xor: Remove unused 'async_xor_val'

[Dr. David Alan Gilbert]

* Herbert Xu (herbert@gondor.apana.org.au) wrote:
> On Sun, Sep 29, 2024 at 02:21:48PM +0100, linux@treblig.org wrote:
> > From: "Dr. David Alan Gilbert" <linux@treblig.org>
> > 
> > async_xor_val has been unused since commit
> > a7c224a820c3 ("md/raid5: convert to new xor compution interface")
> > 
> > Remove it.
> > 
> > Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> > ---
> >  crypto/async_tx/async_xor.c | 26 --------------------------
> >  include/linux/async_tx.h    |  5 -----
> >  2 files changed, 31 deletions(-)
> 
> Patch applied.  Thanks.

Thanks!

Dave

> -- 
> Email: Herbert Xu <herbert@gondor.apana.org.au>
> Home Page: http://gondor.apana.org.au/~herbert/
> PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
> 
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/