public inbox for linux-crypto@vger.kernel.org
 help / color / mirror / Atom feed
From: Eric Biggers <ebiggers@kernel.org>
To: Ard Biesheuvel <ardb+git@google.com>
Cc: linux-crypto@vger.kernel.org, herbert@gondor.apana.org.au,
	Ard Biesheuvel <ardb@kernel.org>
Subject: Re: [PATCH v2 0/2] crypto: Enable fuzz testing for arch code
Date: Wed, 16 Oct 2024 14:52:08 -0700	[thread overview]
Message-ID: <20241016215208.GA1742@sol.localdomain> (raw)
In-Reply-To: <20241016185722.400643-4-ardb+git@google.com>

On Wed, Oct 16, 2024 at 08:57:23PM +0200, Ard Biesheuvel wrote:
> From: Ard Biesheuvel <ardb@kernel.org>
> 
> Follow-up to [0].
> 
> crc32-generic and crc32c-generic are built around the architecture
> library code for CRC-32, and the lack of distinct drivers for this arch
> code means they are lacking test coverage.
> 
> Fix this by exposing the arch library code as a separate driver (with a
> higher priority) if it is different from the generic C code. Update the
> crc32-generic drivers to always use the generic C code.
> 
> Changes since [0]:
> - make generic drivers truly generic, and expose the arch code as a
>   separate driver
> 
> [0] https://lore.kernel.org/all/20241015141514.3000757-4-ardb+git@google.com/T/#u
> 
> Ard Biesheuvel (2):
>   crypto/crc32: Provide crc32-arch driver for accelerated library code
>   crypto/crc32c: Provide crc32c-arch driver for accelerated library code
> 
>  crypto/Makefile         |  2 +
>  crypto/crc32_generic.c  | 94 +++++++++++++++-----
>  crypto/crc32c_generic.c | 94 +++++++++++++++-----
>  lib/crc32.c             |  4 +
>  4 files changed, 148 insertions(+), 46 deletions(-)

Reviewed-by: Eric Biggers <ebiggers@google.com>

- Eric

  parent reply	other threads:[~2024-10-16 21:52 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-16 18:57 [PATCH v2 0/2] crypto: Enable fuzz testing for arch code Ard Biesheuvel
2024-10-16 18:57 ` [PATCH v2 1/2] crypto/crc32: Provide crc32-arch driver for accelerated library code Ard Biesheuvel
2024-10-16 18:57 ` [PATCH v2 2/2] crypto/crc32c: Provide crc32c-arch " Ard Biesheuvel
2024-10-16 21:52 ` Eric Biggers [this message]
2024-10-26  6:58 ` [PATCH v2 0/2] crypto: Enable fuzz testing for arch code Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241016215208.GA1742@sol.localdomain \
    --to=ebiggers@kernel.org \
    --cc=ardb+git@google.com \
    --cc=ardb@kernel.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-crypto@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox