Re: [PATCH v2 04/18] crypto: crc32 - don't unnecessarily register arch algorithms

Herbert Xu
2024-11-02T11:09:00Z

On Sat, Nov 02, 2024 at 12:05:01PM +0100, Ard Biesheuvel wrote:
>
> The only issue resulting from *not* taking this patch is that btrfs
> may misidentify the CRC32 implementation as being 'slow' and take an
> alternative code path, which does not necessarily result in worse
> performance.

If we were removing crc32* (or at least crc32*-arch) from the Crypto
API then these patches would be redundant. But if we're keeping them
because btrfs uses them then we should definitely make crc32*-arch
do the right thing. IOW they should not be registered if they're
the same as crc32*-generic.

Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt