From: Denis Plotnikov <den-plotnikov@yandex-team.ru>
To: linux-crypto@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, john.allen@amd.com,
thomas.lendacky@amd.com
Subject: [PATCH v1] drivers/crypto/ccp: change signature of sp_init()
Date: Thu, 19 Dec 2024 11:12:21 +0300 [thread overview]
Message-ID: <20241219081221.702806-1-den-plotnikov@yandex-team.ru> (raw)
It always returns 0 so make it void instead of int.
Signed-off-by: Denis Plotnikov <den-plotnikov@yandex-team.ru>
---
drivers/crypto/ccp/sp-dev.c | 3 +--
drivers/crypto/ccp/sp-dev.h | 2 +-
drivers/crypto/ccp/sp-pci.c | 4 +---
drivers/crypto/ccp/sp-platform.c | 4 +---
4 files changed, 4 insertions(+), 9 deletions(-)
diff --git a/drivers/crypto/ccp/sp-dev.c b/drivers/crypto/ccp/sp-dev.c
index 7eb3e46682860..bd6800dc190ca 100644
--- a/drivers/crypto/ccp/sp-dev.c
+++ b/drivers/crypto/ccp/sp-dev.c
@@ -188,7 +188,7 @@ struct sp_device *sp_alloc_struct(struct device *dev)
return sp;
}
-int sp_init(struct sp_device *sp)
+void sp_init(struct sp_device *sp)
{
sp_add_device(sp);
@@ -197,7 +197,6 @@ int sp_init(struct sp_device *sp)
if (sp->dev_vdata->psp_vdata)
psp_dev_init(sp);
- return 0;
}
void sp_destroy(struct sp_device *sp)
diff --git a/drivers/crypto/ccp/sp-dev.h b/drivers/crypto/ccp/sp-dev.h
index 6f9d7063257d7..89146a41a228d 100644
--- a/drivers/crypto/ccp/sp-dev.h
+++ b/drivers/crypto/ccp/sp-dev.h
@@ -136,7 +136,7 @@ void sp_platform_exit(void);
struct sp_device *sp_alloc_struct(struct device *dev);
-int sp_init(struct sp_device *sp);
+void sp_init(struct sp_device *sp);
void sp_destroy(struct sp_device *sp);
int sp_suspend(struct sp_device *sp);
diff --git a/drivers/crypto/ccp/sp-pci.c b/drivers/crypto/ccp/sp-pci.c
index 248d98fd8c48d..60ae129997481 100644
--- a/drivers/crypto/ccp/sp-pci.c
+++ b/drivers/crypto/ccp/sp-pci.c
@@ -299,9 +299,7 @@ static int sp_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id)
dev_set_drvdata(dev, sp);
- ret = sp_init(sp);
- if (ret)
- goto free_irqs;
+ sp_init(sp);
return 0;
diff --git a/drivers/crypto/ccp/sp-platform.c b/drivers/crypto/ccp/sp-platform.c
index 3933cac1694d4..5abe531edb48c 100644
--- a/drivers/crypto/ccp/sp-platform.c
+++ b/drivers/crypto/ccp/sp-platform.c
@@ -161,9 +161,7 @@ static int sp_platform_probe(struct platform_device *pdev)
dev_set_drvdata(dev, sp);
- ret = sp_init(sp);
- if (ret)
- goto e_err;
+ sp_init(sp);
dev_notice(dev, "enabled\n");
--
2.34.1
reply other threads:[~2024-12-19 8:14 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241219081221.702806-1-den-plotnikov@yandex-team.ru \
--to=den-plotnikov@yandex-team.ru \
--cc=john.allen@amd.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=thomas.lendacky@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox