From: Eric Biggers <ebiggers@kernel.org>
To: linux-crypto@vger.kernel.org
Subject: [PATCH 03/29] crypto: skcipher - remove redundant clamping to page size
Date: Sat, 21 Dec 2024 01:10:30 -0800 [thread overview]
Message-ID: <20241221091056.282098-4-ebiggers@kernel.org> (raw)
In-Reply-To: <20241221091056.282098-1-ebiggers@kernel.org>
From: Eric Biggers <ebiggers@google.com>
In the case where skcipher_walk_next() allocates a bounce page, that
page by definition has size PAGE_SIZE. The number of bytes to copy 'n'
is guaranteed to fit in it, since earlier in the function it was clamped
to be at most a page. Therefore remove the unnecessary logic that tried
to clamp 'n' again to fit in the bounce page.
Signed-off-by: Eric Biggers <ebiggers@google.com>
---
crypto/skcipher.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/crypto/skcipher.c b/crypto/skcipher.c
index 887cbce8f78d..c627e267b125 100644
--- a/crypto/skcipher.c
+++ b/crypto/skcipher.c
@@ -248,28 +248,24 @@ static int skcipher_walk_next(struct skcipher_walk *walk)
return skcipher_walk_done(walk, -EINVAL);
slow_path:
return skcipher_next_slow(walk, bsize);
}
+ walk->nbytes = n;
if (unlikely((walk->in.offset | walk->out.offset) & walk->alignmask)) {
if (!walk->page) {
gfp_t gfp = skcipher_walk_gfp(walk);
walk->page = (void *)__get_free_page(gfp);
if (!walk->page)
goto slow_path;
}
-
- walk->nbytes = min_t(unsigned, n,
- PAGE_SIZE - offset_in_page(walk->page));
walk->flags |= SKCIPHER_WALK_COPY;
return skcipher_next_copy(walk);
}
- walk->nbytes = n;
-
return skcipher_next_fast(walk);
}
static int skcipher_copy_iv(struct skcipher_walk *walk)
{
--
2.47.1
next prev parent reply other threads:[~2024-12-21 9:11 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-21 9:10 [PATCH 00/29] crypto: scatterlist handling improvements Eric Biggers
2024-12-21 9:10 ` [PATCH 01/29] crypto: skcipher - document skcipher_walk_done() and rename some vars Eric Biggers
2024-12-21 9:10 ` [PATCH 02/29] crypto: skcipher - remove unnecessary page alignment of bounce buffer Eric Biggers
2024-12-21 9:10 ` Eric Biggers [this message]
2024-12-21 9:10 ` [PATCH 04/29] crypto: skcipher - remove redundant check for SKCIPHER_WALK_SLOW Eric Biggers
2024-12-21 9:10 ` [PATCH 05/29] crypto: skcipher - fold skcipher_walk_skcipher() into skcipher_walk_virt() Eric Biggers
2024-12-21 9:10 ` [PATCH 06/29] crypto: skcipher - clean up initialization of skcipher_walk::flags Eric Biggers
2024-12-21 9:10 ` [PATCH 07/29] crypto: skcipher - optimize initializing skcipher_walk fields Eric Biggers
2024-12-21 11:16 ` Herbert Xu
2024-12-29 22:10 ` Eric Biggers
2025-01-02 1:03 ` Herbert Xu
2024-12-21 9:10 ` [PATCH 08/29] crypto: skcipher - call cond_resched() directly Eric Biggers
2024-12-21 9:10 ` [PATCH 09/29] crypto: omap - switch from scatter_walk to plain offset Eric Biggers
2024-12-21 9:10 ` [PATCH 10/29] crypto: powerpc/p10-aes-gcm - simplify handling of linear associated data Eric Biggers
2024-12-21 9:10 ` [PATCH 11/29] crypto: scatterwalk - move to next sg entry just in time Eric Biggers
2024-12-21 9:10 ` [PATCH 12/29] crypto: scatterwalk - add new functions for skipping data Eric Biggers
2024-12-21 9:10 ` [PATCH 13/29] crypto: scatterwalk - add new functions for iterating through data Eric Biggers
2024-12-21 11:27 ` Herbert Xu
2024-12-23 19:53 ` Eric Biggers
2024-12-21 9:10 ` [PATCH 14/29] crypto: scatterwalk - add new functions for copying data Eric Biggers
2024-12-21 9:10 ` [PATCH 15/29] crypto: skcipher - use scatterwalk_start_at_pos() Eric Biggers
2024-12-21 9:10 ` [PATCH 16/29] crypto: aegis - use the new scatterwalk functions Eric Biggers
2024-12-21 9:10 ` [PATCH 17/29] crypto: arm/ghash " Eric Biggers
2024-12-21 9:10 ` [PATCH 18/29] crypto: arm64 " Eric Biggers
2024-12-21 9:10 ` [PATCH 19/29] crypto: keywrap " Eric Biggers
2024-12-21 9:10 ` [PATCH 20/29] crypto: nx " Eric Biggers
2024-12-21 9:10 ` [PATCH 21/29] crypto: s390/aes-gcm " Eric Biggers
2024-12-21 9:10 ` [PATCH 22/29] crypto: s5p-sss " Eric Biggers
2024-12-21 9:10 ` [PATCH 23/29] crypto: stm32 " Eric Biggers
2024-12-21 9:10 ` [PATCH 24/29] crypto: x86/aes-gcm " Eric Biggers
2024-12-21 9:10 ` [PATCH 25/29] crypto: x86/aegis " Eric Biggers
2024-12-21 9:10 ` [PATCH 26/29] net/tls: " Eric Biggers
2024-12-23 15:48 ` Jakub Kicinski
2024-12-23 19:42 ` Eric Biggers
2024-12-23 20:44 ` Jakub Kicinski
2024-12-29 23:58 ` Eric Biggers
2024-12-21 9:10 ` [PATCH 27/29] crypto: skcipher - " Eric Biggers
2024-12-21 9:10 ` [PATCH 28/29] crypto: scatterwalk - remove obsolete functions Eric Biggers
2024-12-21 9:10 ` [PATCH 29/29] crypto: scatterwalk - don't split at page boundaries when !HIGHMEM Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241221091056.282098-4-ebiggers@kernel.org \
--to=ebiggers@kernel.org \
--cc=linux-crypto@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox