Re: [PATCH 26/29] net/tls: use the new scatterwalk functions

Jakub Kicinski
2024-12-23T15:48:27Z

On Sat, 21 Dec 2024 01:10:53 -0800 Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
>
> Replace calls to the deprecated function scatterwalk_copychunks() with
> memcpy_from_scatterwalk(), memcpy_to_scatterwalk(), or
> scatterwalk_skip() as appropriate.
>
> The new functions behave more as expected and eliminate the need to call
> scatterwalk_done() or scatterwalk_pagedone(). This was not always being
> done when needed, and therefore the old code appears to have also had a
> bug where the dcache of the destination page(s) was not always being
> flushed on architectures that need that.
>
> Cc: Boris Pismenny <borisp@nvidia.com>
> Cc: Jakub Kicinski <kuba@kernel.org>
> Cc: John Fastabend <john.fastabend@gmail.com>
> Cc: netdev@vger.kernel.org
> Signed-off-by: Eric Biggers <ebiggers@google.com>

Acked-by: Jakub Kicinski <kuba@kernel.org>