From: Eric Biggers <ebiggers@kernel.org>
To: linux-crypto@vger.kernel.org
Subject: [PATCH v3 5/8] crypto: skcipher - fold skcipher_walk_skcipher() into skcipher_walk_virt()
Date: Sun, 5 Jan 2025 11:34:13 -0800 [thread overview]
Message-ID: <20250105193416.36537-6-ebiggers@kernel.org> (raw)
In-Reply-To: <20250105193416.36537-1-ebiggers@kernel.org>
From: Eric Biggers <ebiggers@google.com>
Fold skcipher_walk_skcipher() into skcipher_walk_virt() which is its
only remaining caller. No change in behavior.
Signed-off-by: Eric Biggers <ebiggers@google.com>
---
crypto/skcipher.c | 23 ++++++++---------------
1 file changed, 8 insertions(+), 15 deletions(-)
diff --git a/crypto/skcipher.c b/crypto/skcipher.c
index 98606def1bf9..17f4bc79ca8b 100644
--- a/crypto/skcipher.c
+++ b/crypto/skcipher.c
@@ -304,23 +304,26 @@ static int skcipher_walk_first(struct skcipher_walk *walk)
walk->page = NULL;
return skcipher_walk_next(walk);
}
-static int skcipher_walk_skcipher(struct skcipher_walk *walk,
- struct skcipher_request *req)
+int skcipher_walk_virt(struct skcipher_walk *walk,
+ struct skcipher_request *req, bool atomic)
{
struct crypto_skcipher *tfm = crypto_skcipher_reqtfm(req);
struct skcipher_alg *alg = crypto_skcipher_alg(tfm);
+ int err = 0;
+
+ might_sleep_if(req->base.flags & CRYPTO_TFM_REQ_MAY_SLEEP);
walk->total = req->cryptlen;
walk->nbytes = 0;
walk->iv = req->iv;
walk->oiv = req->iv;
if (unlikely(!walk->total))
- return 0;
+ goto out;
scatterwalk_start(&walk->in, req->src);
scatterwalk_start(&walk->out, req->dst);
walk->flags &= ~SKCIPHER_WALK_SLEEP;
@@ -334,22 +337,12 @@ static int skcipher_walk_skcipher(struct skcipher_walk *walk,
if (alg->co.base.cra_type != &crypto_skcipher_type)
walk->stride = alg->co.chunksize;
else
walk->stride = alg->walksize;
- return skcipher_walk_first(walk);
-}
-
-int skcipher_walk_virt(struct skcipher_walk *walk,
- struct skcipher_request *req, bool atomic)
-{
- int err;
-
- might_sleep_if(req->base.flags & CRYPTO_TFM_REQ_MAY_SLEEP);
-
- err = skcipher_walk_skcipher(walk, req);
-
+ err = skcipher_walk_first(walk);
+out:
walk->flags &= atomic ? ~SKCIPHER_WALK_SLEEP : ~0;
return err;
}
EXPORT_SYMBOL_GPL(skcipher_walk_virt);
--
2.47.1
next prev parent reply other threads:[~2025-01-05 19:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-05 19:34 [PATCH v3 0/8] crypto: skcipher_walk cleanups Eric Biggers
2025-01-05 19:34 ` [PATCH v3 1/8] crypto: skcipher - document skcipher_walk_done() and rename some vars Eric Biggers
2025-01-05 19:34 ` [PATCH v3 2/8] crypto: skcipher - remove unnecessary page alignment of bounce buffer Eric Biggers
2025-01-05 19:34 ` [PATCH v3 3/8] crypto: skcipher - remove redundant clamping to page size Eric Biggers
2025-01-05 19:34 ` [PATCH v3 4/8] crypto: skcipher - remove redundant check for SKCIPHER_WALK_SLOW Eric Biggers
2025-01-05 19:34 ` Eric Biggers [this message]
2025-01-05 19:34 ` [PATCH v3 6/8] crypto: skcipher - clean up initialization of skcipher_walk::flags Eric Biggers
2025-01-05 19:34 ` [PATCH v3 7/8] crypto: skcipher - optimize initializing skcipher_walk fields Eric Biggers
2025-01-05 19:34 ` [PATCH v3 8/8] crypto: skcipher - call cond_resched() directly Eric Biggers
2025-01-14 3:46 ` [PATCH v3 0/8] crypto: skcipher_walk cleanups Herbert Xu
2025-01-15 2:40 ` Eric Biggers
2025-01-15 4:42 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250105193416.36537-6-ebiggers@kernel.org \
--to=ebiggers@kernel.org \
--cc=linux-crypto@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).