From: Eric Biggers <ebiggers@kernel.org>
To: linux-crypto@vger.kernel.org
Subject: [PATCH v3 8/8] crypto: skcipher - call cond_resched() directly
Date: Sun, 5 Jan 2025 11:34:16 -0800 [thread overview]
Message-ID: <20250105193416.36537-9-ebiggers@kernel.org> (raw)
In-Reply-To: <20250105193416.36537-1-ebiggers@kernel.org>
From: Eric Biggers <ebiggers@google.com>
In skcipher_walk_done(), instead of calling crypto_yield() which
requires a translation between flags, just call cond_resched() directly.
This has the same effect.
Signed-off-by: Eric Biggers <ebiggers@google.com>
---
crypto/skcipher.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/crypto/skcipher.c b/crypto/skcipher.c
index 6b62d816f08d..a9eb2dcf2898 100644
--- a/crypto/skcipher.c
+++ b/crypto/skcipher.c
@@ -144,12 +144,12 @@ int skcipher_walk_done(struct skcipher_walk *walk, int res)
scatterwalk_advance(&walk->out, n);
scatterwalk_done(&walk->in, 0, total);
scatterwalk_done(&walk->out, 1, total);
if (total) {
- crypto_yield(walk->flags & SKCIPHER_WALK_SLEEP ?
- CRYPTO_TFM_REQ_MAY_SLEEP : 0);
+ if (walk->flags & SKCIPHER_WALK_SLEEP)
+ cond_resched();
walk->flags &= ~(SKCIPHER_WALK_SLOW | SKCIPHER_WALK_COPY |
SKCIPHER_WALK_DIFF);
return skcipher_walk_next(walk);
}
--
2.47.1
next prev parent reply other threads:[~2025-01-05 19:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-05 19:34 [PATCH v3 0/8] crypto: skcipher_walk cleanups Eric Biggers
2025-01-05 19:34 ` [PATCH v3 1/8] crypto: skcipher - document skcipher_walk_done() and rename some vars Eric Biggers
2025-01-05 19:34 ` [PATCH v3 2/8] crypto: skcipher - remove unnecessary page alignment of bounce buffer Eric Biggers
2025-01-05 19:34 ` [PATCH v3 3/8] crypto: skcipher - remove redundant clamping to page size Eric Biggers
2025-01-05 19:34 ` [PATCH v3 4/8] crypto: skcipher - remove redundant check for SKCIPHER_WALK_SLOW Eric Biggers
2025-01-05 19:34 ` [PATCH v3 5/8] crypto: skcipher - fold skcipher_walk_skcipher() into skcipher_walk_virt() Eric Biggers
2025-01-05 19:34 ` [PATCH v3 6/8] crypto: skcipher - clean up initialization of skcipher_walk::flags Eric Biggers
2025-01-05 19:34 ` [PATCH v3 7/8] crypto: skcipher - optimize initializing skcipher_walk fields Eric Biggers
2025-01-05 19:34 ` Eric Biggers [this message]
2025-01-14 3:46 ` [PATCH v3 0/8] crypto: skcipher_walk cleanups Herbert Xu
2025-01-15 2:40 ` Eric Biggers
2025-01-15 4:42 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250105193416.36537-9-ebiggers@kernel.org \
--to=ebiggers@kernel.org \
--cc=linux-crypto@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).