public inbox for linux-crypto@vger.kernel.org
 help / color / mirror / Atom feed
From: Eric Biggers <ebiggers@kernel.org>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
	"David S. Miller" <davem@davemloft.net>,
	"Justin M. Forbes" <jforbes@fedoraproject.org>,
	"Jason A. Donenfeld" <Jason@zx2c4.com>,
	Arnd Bergmann <arnd@arndb.de>, Ard Biesheuvel <ardb@kernel.org>,
	Jarkko Sakkinen <jarkko@kernel.org>,
	James Bottomley <James.Bottomley@hansenpartnership.com>,
	linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] crypto: lib/Kconfig: hide library options
Date: Mon, 10 Mar 2025 10:27:34 -0700	[thread overview]
Message-ID: <20250310172734.GE1701@sol.localdomain> (raw)
In-Reply-To: <20250310132647.3256818-2-arnd@kernel.org>

On Mon, Mar 10, 2025 at 02:26:40PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> Any driver that needs these library functions should already be selecting
> the corresponding Kconfig symbols, so there is no real point in making
> these visible.
> 
> The original patch that made these user selectable described problems
> with drivers failing to select the code they use, but as far as I can
> tell, those were all bugs that got solved in the meantime and did not
> get solved by that patch.
> 
> Fixes: e56e18985596 ("lib/crypto: add prompts back to crypto libraries")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ----
> This does not actually fix a build failure, but I noticed that the
> user visible options don't really make sense. Feel free to ignore
> this one.

Acked-by: Eric Biggers <ebiggers@kernel.org>

But I think the following needs to be fixed first:

    config BIG_KEYS
            bool "Large payload keys"
            depends on KEYS
            depends on TMPFS
            depends on CRYPTO_LIB_CHACHA20POLY1305 = y

- Eric

  reply	other threads:[~2025-03-10 17:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-10 13:26 [PATCH 1/2] crypto: fix dependencies on lib/crypto modules Arnd Bergmann
2025-03-10 13:26 ` [PATCH 2/2] crypto: lib/Kconfig: hide library options Arnd Bergmann
2025-03-10 17:27   ` Eric Biggers [this message]
2025-03-10 17:24 ` [PATCH 1/2] crypto: fix dependencies on lib/crypto modules Eric Biggers
2025-03-11 12:32   ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250310172734.GE1701@sol.localdomain \
    --to=ebiggers@kernel.org \
    --cc=James.Bottomley@hansenpartnership.com \
    --cc=Jason@zx2c4.com \
    --cc=ardb@kernel.org \
    --cc=arnd@arndb.de \
    --cc=arnd@kernel.org \
    --cc=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=jarkko@kernel.org \
    --cc=jforbes@fedoraproject.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox