Re: [PATCH 2/2] crypto: arm/aes-neonbs - stop using the SIMD helper

Eric Biggers
2025-04-02T17:30:27Z

On Wed, Apr 02, 2025 at 09:02:53AM +0200, Ard Biesheuvel wrote:
> From: Ard Biesheuvel <ardb@kernel.org>
>
> Now that ARM permits use of the NEON unit in softirq context as well as
> task context, there is no longer a need to rely on the SIMD helper
> module to construct async skciphers wrapping the sync ones, as the
> latter can always be called directly.
>
> So remove these wrappers and the dependency on the SIMD helper. This
> permits the use of these algorithms by callers that only support
> synchronous use.
>
> Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
> ---
> arch/arm/crypto/Kconfig | 1 -
> arch/arm/crypto/aes-neonbs-glue.c | 114 +++---------------------------
> 2 files changed, 9 insertions(+), 106 deletions(-)
>
> diff --git a/arch/arm/crypto/Kconfig b/arch/arm/crypto/Kconfig
> index 2fa8aba8dc12..ba1d1b67c727 100644
> --- a/arch/arm/crypto/Kconfig
> +++ b/arch/arm/crypto/Kconfig
> @@ -169,7 +169,6 @@ config CRYPTO_AES_ARM_BS
> select CRYPTO_AES_ARM
> select CRYPTO_SKCIPHER
> select CRYPTO_LIB_AES
> - select CRYPTO_SIMD
> help
> Length-preserving ciphers: AES cipher algorithms (FIPS-197)
> with block cipher modes:
> diff --git a/arch/arm/crypto/aes-neonbs-glue.c b/arch/arm/crypto/aes-neonbs-glue.c
> index f6be80b5938b..63800257a7ea 100644
> --- a/arch/arm/crypto/aes-neonbs-glue.c
> +++ b/arch/arm/crypto/aes-neonbs-glue.c

The following includes can now be removed from this file:

#include <crypto/ctr.h>
#include <crypto/internal/simd.h>

Otherwise this patch looks good. Thanks!

Reviewed-by: Eric Biggers <ebiggers@kernel.org>

- Eric