Re: [PATCH 1/2] crypto: arm/aes-ce - stop using the SIMD helper

Eric Biggers
2025-04-02T17:32:57Z

On Wed, Apr 02, 2025 at 09:02:52AM +0200, Ard Biesheuvel wrote:
> From: Ard Biesheuvel <ardb@kernel.org>
>
> Now that ARM permits use of the NEON unit in softirq context as well as
> task context, there is no longer a need to rely on the SIMD helper
> module to construct async skciphers wrapping the sync ones, as the
> latter can always be called directly.
>
> So remove these wrappers and the dependency on the SIMD helper. This
> permits the use of these algorithms by callers that only support
> synchronous use.
>
> Signed-off-by: Ard Biesheuvel <ardb@kernel.org>
> ---
> arch/arm/crypto/Kconfig | 1 -
> arch/arm/crypto/aes-ce-glue.c | 102 ++++------------------------------
> 2 files changed, 11 insertions(+), 92 deletions(-)
>
> diff --git a/arch/arm/crypto/Kconfig b/arch/arm/crypto/Kconfig
> index 32650c8431d9..2fa8aba8dc12 100644
> --- a/arch/arm/crypto/Kconfig
> +++ b/arch/arm/crypto/Kconfig
> @@ -197,7 +197,6 @@ config CRYPTO_AES_ARM_CE
> depends on KERNEL_MODE_NEON
> select CRYPTO_SKCIPHER
> select CRYPTO_LIB_AES
> - select CRYPTO_SIMD
> help
> Length-preserving ciphers: AES cipher algorithms (FIPS-197)
> with block cipher modes:
> diff --git a/arch/arm/crypto/aes-ce-glue.c b/arch/arm/crypto/aes-ce-glue.c
> index 21df5e7f51f9..c17d9e4ad8e6 100644
> --- a/arch/arm/crypto/aes-ce-glue.c
> +++ b/arch/arm/crypto/aes-ce-glue.c

The following includes can now be removed from this file:

#include <crypto/ctr.h>
#include <crypto/internal/simd.h>

Otherwise this patch looks good. Thanks!

Reviewed-by: Eric Biggers <ebiggers@kernel.org>

- Eric