Re: [PATCH 00/15] crypto: lib - Add partial block helper

[Eric Biggers <ebiggers@kernel.org>]

On Thu, Apr 24, 2025 at 06:46:56PM +0800, Herbert Xu wrote:
> This is based on
> 
> 	https://patchwork.kernel.org/project/linux-crypto/patch/20250422152151.3691-2-ebiggers@kernel.org/
> 	https://patchwork.kernel.org/project/linux-crypto/patch/20250422152716.5923-2-ebiggers@kernel.org/
> 	https://patchwork.kernel.org/project/linux-crypto/patch/2ea17454f213a54134340b25f70a33cd3f26be37.1745399917.git.herbert@gondor.apana.org.au/
> 
> This series introduces a partial block helper for lib/crypto hash
> algorithms based on the one from sha256_base.
> 
> It then uses it on poly1305 to eliminate duplication between
> architectures.  In particular, instead of having complete update
> functions for each architecture, reduce it to a block function
> per architecture instead.  The partial block handling is handled
> by the generic library layer.
> 
> The poly1305 implementation was anomalous due to the inability
> to call setkey in softirq.  This has since been resolved with
> the addition of cloning.  Add setkey to poly1305 and switch the
> IPsec code (rfc7539) to use that.
> 
> Finally add a partial blocks conversion for polyval.

Why aren't the POLYVAL changes in their own patch series?

Touching SHA-256 (which again, I'm currently working on fixing properly, so I
keep having to rebase on top of your random changes which will be superseded
anyway) also seems to be unnecessary.

- Eric