Re: [PATCH] firmware_loader: use SHA-256 library API instead of crypto_shash API

Eric Biggers
2025-04-29T16:42:25Z

On Tue, Apr 29, 2025 at 07:54:42AM +0200, Greg Kroah-Hartman wrote:
> On Mon, Apr 28, 2025 at 12:09:09PM -0700, Eric Biggers wrote:
> > From: Eric Biggers <ebiggers@google.com>
> >
> > This user of SHA-256 does not support any other algorithm, so the
> > crypto_shash abstraction provides no value. Just use the SHA-256
> > library API instead, which is much simpler and easier to use.
> >
> > Also take advantage of printk's built-in hex conversion using %*phN.
> >
> > Signed-off-by: Eric Biggers <ebiggers@google.com>
> > ---
> >
> > This patch is targeting the firmware_loader tree for 6.16.
>
>
> Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Greg, it looks like you normally take patches to this file. You can go ahead
and take it if you want. Thanks!

- Eric