Re: [v2 PATCH] Revert "crypto: run initcalls for generic implementations earlier"

[Eric Biggers <ebiggers@kernel.org>]

On Wed, Apr 30, 2025 at 04:17:02PM +0800, Herbert Xu wrote:
> v2 moves lib/crypto to subsys_initcall en masse and removes the
> blake2s patch.
> 
> ---8<---
> This reverts commit c4741b23059794bd99beef0f700103b0d983b3fd.
> 
> Crypto API self-tests no longer run at registration time and now
> occur either at late_initcall or upon the first use.
> 
> Therefore the premise of the above commit no longer exists.  Revert
> it and subsequent additions of subsys_initcall and arch_initcall.
> 
> Note that lib/crypto calls will stay at subsys_initcall (or rather
> downgraded from arch_initcall) because they may need to occur
> before Crypto API registration.
> 
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

The commit message shouldn't pretend that this is a 'git revert', since clearly
a lot of these changes were made by hand.

Otherwise this generally looks fine, but I also don't know where this applies
to, so I can't properly review it.

- Eric