public inbox for linux-crypto@vger.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Herbert Xu <herbert@gondor.apana.org.au>,
	Linux Crypto Mailing List <linux-crypto@vger.kernel.org>
Cc: oe-kbuild-all@lists.linux.dev
Subject: Re: [PATCH 2/6] crypto: ahash - Handle partial blocks in API
Date: Fri, 9 May 2025 06:03:51 +0800	[thread overview]
Message-ID: <202505090505.7uAKB19V-lkp@intel.com> (raw)
In-Reply-To: <26a6ba5a71b8848c6e79757a596ecc3838bf320e.1746448291.git.herbert@gondor.apana.org.au>

Hi Herbert,

kernel test robot noticed the following build warnings:

[auto build test WARNING on herbert-cryptodev-2.6/master]
[also build test WARNING on next-20250508]
[cannot apply to herbert-crypto-2.6/master linus/master v6.15-rc5]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Herbert-Xu/crypto-ahash-Handle-partial-blocks-in-API/20250505-203411
base:   https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master
patch link:    https://lore.kernel.org/r/26a6ba5a71b8848c6e79757a596ecc3838bf320e.1746448291.git.herbert%40gondor.apana.org.au
patch subject: [PATCH 2/6] crypto: ahash - Handle partial blocks in API
config: nios2-randconfig-r073-20250509 (https://download.01.org/0day-ci/archive/20250509/202505090505.7uAKB19V-lkp@intel.com/config)
compiler: nios2-linux-gcc (GCC) 13.3.0

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202505090505.7uAKB19V-lkp@intel.com/

smatch warnings:
crypto/ahash.c:370 ahash_do_req_chain() warn: inconsistent indenting

vim +370 crypto/ahash.c

   338	
   339	static int ahash_do_req_chain(struct ahash_request *req,
   340				      int (*const *op)(struct ahash_request *req))
   341	{
   342		struct crypto_ahash *tfm = crypto_ahash_reqtfm(req);
   343		int err;
   344	
   345		if (crypto_ahash_req_virt(tfm) || !ahash_request_isvirt(req))
   346			return (*op)(req);
   347	
   348		if (crypto_ahash_statesize(tfm) > HASH_MAX_STATESIZE)
   349			return -ENOSYS;
   350	
   351		{
   352			u8 state[HASH_MAX_STATESIZE];
   353	
   354			if (op == &crypto_ahash_alg(tfm)->digest) {
   355				ahash_request_set_tfm(req, crypto_ahash_fb(tfm));
   356				err = crypto_ahash_digest(req);
   357				goto out_no_state;
   358			}
   359	
   360			err = crypto_ahash_export(req, state);
   361			ahash_request_set_tfm(req, crypto_ahash_fb(tfm));
   362			err = err ?: crypto_ahash_import(req, state);
   363	
   364			if (op == &crypto_ahash_alg(tfm)->finup) {
   365				err = err ?: crypto_ahash_finup(req);
   366				goto out_no_state;
   367			}
   368	
   369			err = err ?: crypto_ahash_update(req);
 > 370				     crypto_ahash_export(req, state);
   371	
   372			ahash_request_set_tfm(req, tfm);
   373			return err ?: crypto_ahash_import(req, state);
   374	
   375	out_no_state:
   376			ahash_request_set_tfm(req, tfm);
   377			return err;
   378		}
   379	}
   380	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

  reply	other threads:[~2025-05-08 22:04 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-05 12:32 [PATCH 1/6] crypto: hash - Move core export and import into internel/hash.h Herbert Xu
2025-05-05 12:32 ` [PATCH 2/6] crypto: ahash - Handle partial blocks in API Herbert Xu
2025-05-08 22:03   ` kernel test robot [this message]
2025-05-05 12:32 ` [PATCH 3/6] crypto: hmac - Zero shash desc in setkey Herbert Xu
2025-05-05 12:32 ` [PATCH 4/6] crypto: shash - Set reqsize in shash_alg Herbert Xu
2025-05-05 12:32 ` [PATCH 5/6] crypto: algapi - Add driver template support to crypto_inst_setname Herbert Xu
2025-05-05 12:32 ` [PATCH 6/6] crypto: hmac - Add ahash support Herbert Xu
2025-05-10 15:42   ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202505090505.7uAKB19V-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-crypto@vger.kernel.org \
    --cc=oe-kbuild-all@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox