linux-crypto.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Eric Biggers <ebiggers@kernel.org>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Venkat Rao Bagalkote <venkat88@linux.ibm.com>,
	Thorsten Leemhuis <linux@leemhuis.info>,
	Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Linux Next Mailing List <linux-next@vger.kernel.org>,
	Madhavan Srinivasan <maddy@linux.ibm.com>,
	Stephen Rothwell <sfr@canb.auug.org.au>
Subject: Re: [PATCH] crypto: powerpc/poly1305 - Fix input mixup in poly1305_emit_arch
Date: Fri, 9 May 2025 21:44:50 -0700	[thread overview]
Message-ID: <20250510044450.GA505731@sol> (raw)
In-Reply-To: <aB31DI4QBBZuQObQ@gondor.apana.org.au>

On Fri, May 09, 2025 at 08:29:00PM +0800, Herbert Xu wrote:
> On Thu, May 08, 2025 at 08:35:48PM +0530, Venkat Rao Bagalkote wrote:
> >
> > Unfortunately, above patch dosent fix the boot warning.
> 
> This works for me:
> 
> ---8<---
> Swap the order of the arguments in poly1305_emit_arch to match
> the prototype.
> 
> Fixes: 14d31979145d ("crypto: powerpc/poly1305 - Add block-only interface")
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

This fixes "-cpu Power10", but older CPUs (e.g. "-cpu POWER9") are still
failing.

- Eric

  reply	other threads:[~2025-05-10  4:44 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-28  4:56 [v4 PATCH 00/11] crypto: lib - Add partial block helper Herbert Xu
2025-04-28  4:56 ` [v4 PATCH 01/11] crypto: lib/sha256 - Move partial block handling out Herbert Xu
2025-04-28  4:56 ` [v4 PATCH 02/11] crypto: lib/poly1305 - Add block-only interface Herbert Xu
2025-04-28  4:56 ` [v4 PATCH 03/11] crypto: arm/poly1305 " Herbert Xu
2025-04-28  4:56 ` [v4 PATCH 04/11] crypto: arm64/poly1305 " Herbert Xu
2025-04-28  4:56 ` [v4 PATCH 05/11] crypto: mips/poly1305 " Herbert Xu
2025-04-28  4:56 ` [v4 PATCH 06/11] crypto: powerpc/poly1305 " Herbert Xu
2025-04-28  4:56 ` [v4 PATCH 07/11] crypto: x86/poly1305 " Herbert Xu
2025-04-28  4:56 ` [v4 PATCH 08/11] crypto: chacha20poly1305 - Use lib/crypto poly1305 Herbert Xu
2025-05-05 13:41   ` Cabiddu, Giovanni
2025-05-06  2:03     ` Herbert Xu
2025-05-06  2:05       ` [PATCH] crypto: lib/poly1305 - Build main library on LIB_POLY1305 and split generic code out Herbert Xu
2025-05-06 10:56         ` Cabiddu, Giovanni
2025-05-06 11:05           ` [v2 PATCH] " Herbert Xu
2025-05-06 11:30             ` Cabiddu, Giovanni
2025-04-28  4:56 ` [v4 PATCH 09/11] crypto: testmgr - Remove poly1305 Herbert Xu
2025-04-28  4:56 ` [v4 PATCH 10/11] crypto: poly1305 - Remove algorithm Herbert Xu
2025-04-28  4:56 ` [v4 PATCH 11/11] crypto: lib/poly1305 - Use block-only interface Herbert Xu
2025-05-07 11:03   ` Thorsten Leemhuis
2025-05-07 11:36     ` [PATCH] crypto: powerpc/poly1305 - Add missing poly1305_emit_arch Herbert Xu
2025-05-07 12:25       ` Thorsten Leemhuis
2025-05-08  9:16       ` Venkat Rao Bagalkote
2025-05-08  9:31         ` Herbert Xu
2025-05-08 10:01           ` Venkat Rao Bagalkote
2025-05-08 11:10             ` Herbert Xu
2025-05-08  9:45         ` Herbert Xu
2025-05-08 16:29           ` Eric Biggers
2025-05-09  0:53             ` Herbert Xu
2025-05-08  9:49         ` Herbert Xu
2025-05-08 11:39         ` Herbert Xu
2025-05-08 11:57           ` Venkat Rao Bagalkote
2025-05-08 11:59             ` Herbert Xu
2025-05-08 12:23             ` [PATCH] crypto: powerpc/poly1305 - Restore crypto_simd_usable test Herbert Xu
2025-05-08 15:05               ` Venkat Rao Bagalkote
2025-05-09 12:29                 ` [PATCH] crypto: powerpc/poly1305 - Fix input mixup in poly1305_emit_arch Herbert Xu
2025-05-10  4:44                   ` Eric Biggers [this message]
2025-05-10  5:10                     ` [v2 PATCH] crypto: powerpc/poly1305 - Add poly1305_emit_arch wrapper Herbert Xu
2025-05-10  5:33                       ` Eric Biggers
2025-05-10  5:49                         ` Herbert Xu
2025-05-10  5:50                           ` Herbert Xu
2025-05-10  6:02                             ` Eric Biggers
2025-05-10  9:13                         ` [PATCH] crypto: powerpc/poly1305 - Add SIMD fallback Herbert Xu
2025-05-10 22:34                         ` [v2 PATCH] crypto: powerpc/poly1305 - Add poly1305_emit_arch wrapper Segher Boessenkool
2025-05-10 23:19                           ` Eric Biggers
2025-05-11  2:10                           ` Herbert Xu
2025-05-12  5:13                       ` Venkat Rao Bagalkote
2025-05-09 14:16               ` [PATCH] crypto: powerpc/poly1305 - Restore crypto_simd_usable test Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250510044450.GA505731@sol \
    --to=ebiggers@kernel.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=linux@leemhuis.info \
    --cc=maddy@linux.ibm.com \
    --cc=sfr@canb.auug.org.au \
    --cc=venkat88@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).