From: Eric Biggers <ebiggers@kernel.org>
To: Klaus Kudielka <klaus.kudielka@gmail.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
Corentin Labbe <clabbe.montjoie@gmail.com>,
regressions@lists.linux.dev, linux-kernel@vger.kernel.org,
Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
Boris Brezillon <bbrezillon@kernel.org>,
EBALARD Arnaud <Arnaud.Ebalard@ssi.gouv.fr>,
Romain Perier <romain.perier@gmail.com>
Subject: Re: [PATCH] crypto: marvell/cesa - Avoid empty transfer descriptor
Date: Thu, 15 May 2025 11:21:31 -0700 [thread overview]
Message-ID: <20250515182131.GC1411@quark> (raw)
In-Reply-To: <20dde00750d803a9a364ded99dab1e3e22daec77.camel@gmail.com>
On Thu, May 15, 2025 at 07:53:03PM +0200, Klaus Kudielka wrote:
> On Wed, 2025-05-14 at 13:14 +0800, Herbert Xu wrote:
> >
> > Sorry, should've mentioned that this goes on top of the current
> > cryptodev tree:
> >
> > https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git/log/
> >
>
> Okay, so now I have two printk patches on top of the current cryptodev tree.
>
> I have enabled CRYPTO_SELFTESTS
>
> - Three successful reboot / modprobe marvell-cesa. All self-tests passed.
> - But the whole self-tests sequence now take approx. 2 minutes, instead of 15 seconds with plain v6.15-rc5
> - And the journal gets huge. 24k lines. I am attaching a gzipped version, hope this works.
>
> Best regards, Klaus
CRYPTO_SELFTESTS now enables the full set of crypto self-tests, which for the
past 6 years have been needed to be run anyway to properly validate the drivers;
just developers often forgot to enable them because they were under a separate
kconfig option that had a confusing name. So the longer test time is expected.
It's unfortunate that it takes 2 minutes on the platform you're testing (on most
platforms it's much faster), but presumably that is still okay since it's just a
development option? People shouldn't be expecting to run these tests in
production kernels. (But even if they are for some reason, the test time also
remains configurable via kernel command-line options.)
- Eric
next prev parent reply other threads:[~2025-05-15 18:21 UTC|newest]
Thread overview: 77+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <ef7c7a96a73161e0f5061503242a8d3eddef121f.camel@gmail.com>
2024-10-06 9:11 ` [REGRESSION] alg: ahash: Several tests fail during boot on Turris Omnia Herbert Xu
2024-10-06 9:23 ` Klaus Kudielka
2024-10-07 8:27 ` Herbert Xu
2024-10-07 20:57 ` Klaus Kudielka
2024-10-09 8:34 ` Herbert Xu
2024-10-09 8:38 ` [PATCH] crypto: marvell/cesa - Disable hash algorithms Herbert Xu
2024-10-09 16:48 ` [REGRESSION] alg: ahash: Several tests fail during boot on Turris Omnia Klaus Kudielka
2024-10-10 6:05 ` Herbert Xu
2024-10-10 8:24 ` Herbert Xu
2024-10-10 17:35 ` Klaus Kudielka
2024-10-15 4:52 ` Herbert Xu
2024-10-15 17:38 ` Klaus Kudielka
2024-10-16 4:27 ` Herbert Xu
2024-10-16 5:51 ` Klaus Kudielka
2024-10-16 9:53 ` Herbert Xu
2024-11-12 19:33 ` Klaus Kudielka
2024-11-13 9:57 ` Thorsten Leemhuis
2025-05-06 13:19 ` Herbert Xu
2025-05-07 8:43 ` [PATCH] crypto: marvell/cesa - Do not chain submitted requests Herbert Xu
2025-05-07 15:16 ` Corentin Labbe
2025-05-08 5:15 ` [v2 PATCH] " Herbert Xu
2025-05-08 5:22 ` [v3 " Herbert Xu
2025-05-08 12:53 ` Corentin Labbe
2025-05-08 13:10 ` Herbert Xu
2025-05-08 13:43 ` Corentin Labbe
2025-05-09 3:13 ` Herbert Xu
2025-05-09 3:19 ` Herbert Xu
2025-05-09 8:11 ` Herbert Xu
2025-05-09 11:01 ` Corentin Labbe
2025-05-10 1:15 ` Herbert Xu
2025-05-10 1:37 ` Herbert Xu
2025-05-10 1:44 ` Herbert Xu
2025-05-10 10:41 ` [PATCH] crypto: marvell/cesa - Handle zero-length skcipher requests Herbert Xu
2025-05-10 8:32 ` [v3 PATCH] crypto: marvell/cesa - Do not chain submitted requests Klaus Kudielka
2025-05-10 9:05 ` Herbert Xu
2025-05-10 9:38 ` Klaus Kudielka
2025-05-10 10:19 ` Herbert Xu
2025-05-10 10:43 ` [PATCH] crypto: marvell/cesa - Avoid empty transfer descriptor Herbert Xu
2025-05-10 11:14 ` Corentin Labbe
2025-05-10 11:39 ` Herbert Xu
2025-05-10 13:02 ` Herbert Xu
2025-05-10 15:07 ` Klaus Kudielka
2025-05-11 3:22 ` Herbert Xu
2025-05-11 16:39 ` Klaus Kudielka
2025-05-13 9:20 ` Herbert Xu
2025-05-14 5:12 ` Klaus Kudielka
2025-05-14 5:14 ` Herbert Xu
2025-05-15 17:53 ` Klaus Kudielka
2025-05-15 18:21 ` Eric Biggers [this message]
2025-05-15 18:45 ` Klaus Kudielka
2025-05-15 23:25 ` Herbert Xu
2025-05-16 12:41 ` Corentin Labbe
2025-05-16 12:45 ` Herbert Xu
2025-05-17 11:24 ` Corentin Labbe
2025-05-18 7:58 ` Herbert Xu
2025-05-21 5:06 ` Herbert Xu
2025-05-21 9:16 ` Herbert Xu
2025-05-21 9:58 ` Arnd Bergmann
2025-05-21 10:24 ` Herbert Xu
2025-05-21 11:36 ` Arnd Bergmann
2025-05-22 3:13 ` Herbert Xu
2025-05-22 20:08 ` Corentin Labbe
2025-05-21 10:45 ` Corentin Labbe
2025-05-21 10:56 ` Herbert Xu
2025-05-21 13:58 ` Corentin Labbe
2025-05-22 3:01 ` crypto: marvell/cesa - dma_alloc_coherent broken but kmalloc + dma_map_single works Herbert Xu
2025-05-22 7:38 ` Herbert Xu
2025-05-22 20:07 ` Corentin Labbe
2025-05-23 11:46 ` Herbert Xu
2025-05-28 9:58 ` Herbert Xu
2025-05-29 11:17 ` Corentin Labbe
2025-05-22 11:13 ` Herbert Xu
2025-05-16 4:12 ` [PATCH] crypto: marvell/cesa - Avoid empty transfer descriptor Herbert Xu
2025-05-16 17:36 ` Klaus Kudielka
2025-06-17 5:32 ` Klaus Kudielka
2025-06-17 5:36 ` Herbert Xu
2025-05-08 12:49 ` [v2 PATCH] crypto: marvell/cesa - Do not chain submitted requests Corentin Labbe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250515182131.GC1411@quark \
--to=ebiggers@kernel.org \
--cc=Arnaud.Ebalard@ssi.gouv.fr \
--cc=bbrezillon@kernel.org \
--cc=clabbe.montjoie@gmail.com \
--cc=herbert@gondor.apana.org.au \
--cc=klaus.kudielka@gmail.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=regressions@lists.linux.dev \
--cc=romain.perier@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox