From: Eric Biggers <ebiggers@kernel.org>
To: linux-kernel@vger.kernel.org
Cc: linux-crypto@vger.kernel.org, Ard Biesheuvel <ardb@kernel.org>,
"Jason A . Donenfeld " <Jason@zx2c4.com>,
x86@kernel.org
Subject: [PATCH] lib/crc: re-disable optimized CRC code on user-mode Linux
Date: Wed, 11 Jun 2025 22:45:14 -0700 [thread overview]
Message-ID: <20250612054514.142728-1-ebiggers@kernel.org> (raw)
From: Eric Biggers <ebiggers@google.com>
The reorganization of lib/crc/ unintentionally enabled the x86-optimized
CRC64 code on user-mode Linux. (It's enabled when CONFIG_X86_64, which
is set by arch/x86/um/Kconfig. Note that this is a different option
from the "normal" CONFIG_X86_64 which is defined in arch/x86/Kconfig.)
Since this is not being taken into account, a build error results:
CC lib/crc/crc64-main.o
cc1: error: ./lib/crc/um: No such file or directory [-Werror=missing-include-dirs]
lib/crc/crc64-main.c:58:10: fatal error: crc64.h: No such file or directory
58 | #include "crc64.h" /* $(SRCARCH)/crc64.h */
| ^~~~~~~~~
compilation terminated.
cc1: all warnings being treated as errors
Fix this by re-disabling the optimized CRC code on user-mode Linux.
Fixes: e2fd1883971d ("lib/crc: prepare for arch-optimized code in subdirs of lib/crc/")
Signed-off-by: Eric Biggers <ebiggers@google.com>
---
lib/crc/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/crc/Kconfig b/lib/crc/Kconfig
index 5858b3acc6630..70e7a6016de32 100644
--- a/lib/crc/Kconfig
+++ b/lib/crc/Kconfig
@@ -85,10 +85,11 @@ config CRC64_ARCH
default y if RISCV && RISCV_ISA_ZBC && 64BIT
default y if X86_64
config CRC_OPTIMIZATIONS
bool "Enable optimized CRC implementations" if EXPERT
+ depends on !UML
default y
help
Disabling this option reduces code size slightly by disabling the
architecture-optimized implementations of any CRC variants that are
enabled. CRC checksumming performance may get much slower.
base-commit: 7234baeec076d4c2ac05d160ed8cdb2f2d033069
--
2.49.0
next reply other threads:[~2025-06-12 5:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-12 5:45 Eric Biggers [this message]
2025-06-13 18:41 ` [PATCH] lib/crc: re-disable optimized CRC code on user-mode Linux Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250612054514.142728-1-ebiggers@kernel.org \
--to=ebiggers@kernel.org \
--cc=Jason@zx2c4.com \
--cc=ardb@kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox