From: Eric Biggers <ebiggers@kernel.org>
To: linux-crypto@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Ard Biesheuvel <ardb@kernel.org>,
"Jason A . Donenfeld" <Jason@zx2c4.com>
Subject: Re: [PATCH] lib/crypto: Drop inline from all *_mod_init_arch() functions
Date: Wed, 20 Aug 2025 23:39:08 -0400 [thread overview]
Message-ID: <20250821033908.GE185832@quark> (raw)
In-Reply-To: <20250816020457.432040-1-ebiggers@kernel.org>
On Fri, Aug 15, 2025 at 07:04:57PM -0700, Eric Biggers wrote:
> Drop 'inline' from all the *_mod_init_arch() functions so that the
> compiler will warn about any bugs where they are unused due to not being
> wired up properly. (There are no such bugs currently, so this just
> establishes a more robust convention for the future. Of course, these
> functions also tend to get inlined anyway, regardless of the keyword.)
>
> Signed-off-by: Eric Biggers <ebiggers@kernel.org>
> ---
> lib/crypto/arm/sha1.h | 2 +-
> lib/crypto/arm/sha256.h | 2 +-
> lib/crypto/arm/sha512.h | 2 +-
> lib/crypto/arm64/sha1.h | 2 +-
> lib/crypto/arm64/sha256.h | 2 +-
> lib/crypto/arm64/sha512.h | 2 +-
> lib/crypto/riscv/sha256.h | 2 +-
> lib/crypto/riscv/sha512.h | 2 +-
> lib/crypto/s390/sha1.h | 2 +-
> lib/crypto/s390/sha256.h | 2 +-
> lib/crypto/s390/sha512.h | 2 +-
> lib/crypto/sparc/md5.h | 2 +-
> lib/crypto/sparc/sha1.h | 2 +-
> lib/crypto/sparc/sha256.h | 2 +-
> lib/crypto/sparc/sha512.h | 2 +-
> lib/crypto/x86/sha1.h | 2 +-
> lib/crypto/x86/sha256.h | 2 +-
> lib/crypto/x86/sha512.h | 2 +-
> 18 files changed, 18 insertions(+), 18 deletions(-)
Applied to https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/linux.git/log/?h=libcrypto-next
- Eric
prev parent reply other threads:[~2025-08-21 3:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-16 2:04 [PATCH] lib/crypto: Drop inline from all *_mod_init_arch() functions Eric Biggers
2025-08-21 3:39 ` Eric Biggers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250821033908.GE185832@quark \
--to=ebiggers@kernel.org \
--cc=Jason@zx2c4.com \
--cc=ardb@kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox