Linux cryptographic layer development
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Chenghai Huang <huangchenghai2@huawei.com>
Cc: zhangfei.gao@linaro.org, wangzhou1@hisilicon.com,
	linux-kernel@vger.kernel.org, linuxarm@huawei.com,
	linux-crypto@vger.kernel.org, fanghao11@huawei.com,
	shenyang39@huawei.com, qianweili@huawei.com,
	linwenkai6@hisilicon.com, liulongfang@huawei.com
Subject: Re: [PATCH 3/4] uacce: implement mremap in uacce_vm_ops to return -EPERM
Date: Fri, 22 Aug 2025 13:46:07 +0200	[thread overview]
Message-ID: <2025082208-coauthor-pagan-e72c@gregkh> (raw)
In-Reply-To: <20250822103904.3776304-4-huangchenghai2@huawei.com>

On Fri, Aug 22, 2025 at 06:39:03PM +0800, Chenghai Huang wrote:
> From: Yang Shen <shenyang39@huawei.com>
> 
> The current uacce_vm_ops does not support the mremap operation of
> vm_operations_struct. Implement .mremap to return -EPERM to remind
> users

Why is this needed?  If mremap is not set, what is the value returned?

And why is -EPERM the correct value to return here?  That's not what the
man pages say is valid :(

thanks,

greg k-h

  reply	other threads:[~2025-08-22 11:46 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-22 10:39 [PATCH 0/4] uacce: driver fixes for memory leaks and state management Chenghai Huang
2025-08-22 10:39 ` [PATCH 1/4] uacce: fix for cdev memory leak Chenghai Huang
2025-08-22 11:27   ` Greg KH
2025-09-13 10:43     ` huangchenghai
2025-08-25  8:20   ` Zhangfei Gao
2025-08-28 12:59     ` linwenkai (C)
2025-08-22 10:39 ` [PATCH 2/4] uacce: fix isolate sysfs check condition Chenghai Huang
2025-08-22 10:39 ` [PATCH 3/4] uacce: implement mremap in uacce_vm_ops to return -EPERM Chenghai Huang
2025-08-22 11:46   ` Greg KH [this message]
2025-08-28  5:59     ` Zhangfei Gao
2025-09-06 12:03       ` Greg KH
2025-09-08  6:33         ` Zhangfei Gao
2025-09-13 10:40         ` huangchenghai
2025-09-13 11:06           ` Greg KH
2025-09-15  1:48             ` huangchenghai
2025-08-22 10:39 ` [PATCH 4/4] uacce: ensure safe queue release with state management Chenghai Huang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2025082208-coauthor-pagan-e72c@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=fanghao11@huawei.com \
    --cc=huangchenghai2@huawei.com \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxarm@huawei.com \
    --cc=linwenkai6@hisilicon.com \
    --cc=liulongfang@huawei.com \
    --cc=qianweili@huawei.com \
    --cc=shenyang39@huawei.com \
    --cc=wangzhou1@hisilicon.com \
    --cc=zhangfei.gao@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox