From: Eric Biggers <ebiggers@kernel.org>
To: Ilya Dryomov <idryomov@gmail.com>
Cc: ceph-devel@vger.kernel.org, Xiubo Li <xiubli@redhat.com>,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] libceph: Use HMAC-SHA256 library instead of crypto_shash
Date: Thu, 4 Sep 2025 17:25:58 +0000 [thread overview]
Message-ID: <20250904172558.GA854551@google.com> (raw)
In-Reply-To: <CAOi1vP9QRWKoQuYHynTXuupJ=VHhLLtN3s2FE6a+gG6gvrA6SQ@mail.gmail.com>
On Thu, Sep 04, 2025 at 12:24:08PM +0200, Ilya Dryomov wrote:
> > - if (con->v2.hmac_tfm) {
> > - crypto_free_shash(con->v2.hmac_tfm);
> > - con->v2.hmac_tfm = NULL;
> > - }
> > + memzero_explicit(&con->v2.hmac_key, sizeof(con->v2.hmac_key));
> > + con->v2.hmac_key_set = false;
>
> Hi Eric,
>
> Since we have hmac_key_set anyway, could the call to memzero_explicit()
> be conditioned on it?
If you want. It's less code to just do it unconditionally.
- Eric
next prev parent reply other threads:[~2025-09-04 17:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-31 19:02 [PATCH] libceph: Use HMAC-SHA256 library instead of crypto_shash Eric Biggers
2025-07-31 19:25 ` Viacheslav Dubeyko
2025-09-04 2:31 ` Eric Biggers
2025-09-04 10:27 ` Ilya Dryomov
2025-09-04 10:24 ` Ilya Dryomov
2025-09-04 17:25 ` Eric Biggers [this message]
2025-09-08 9:32 ` Ilya Dryomov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250904172558.GA854551@google.com \
--to=ebiggers@kernel.org \
--cc=ceph-devel@vger.kernel.org \
--cc=idryomov@gmail.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=xiubli@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox