From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-171.mta1.migadu.com (out-171.mta1.migadu.com [95.215.58.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 30F0B309EFA for ; Fri, 5 Sep 2025 16:39:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757090374; cv=none; b=YL+EjOeD1o5KmIx5qzyDFE0Zc+O6EsZhiQigrFHC0mPkHOE47Uir5Iy2TnLyTIF16e5pSQbcPeiflIz/NYjVd8On2BtaTXOdRNlLukbak4AnMcuLpod/BCifxc7qw7ug7wsqVuMHc5o7imDNIkawi0Sn+COwjVGC26VX6tgAE8s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757090374; c=relaxed/simple; bh=iEnBzeJ/KbGYG4pzC8D+1DnJX7h1SQpjpRnrfzlCfKE=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=gQfSB8186U2tles7PbikJfUmPlRzlTPaLysJ/RBglqxNokNsziQVXaE7kYWo2l+dHCa6Q9tMSQ4AWfEwei+AZCr8uTiwB4irTBRUTV8yC9oVzOoyGKG1Cxag3vA0de76YcyImpVvD5344pfRQIzDA6idvBO8eIKZ9W2R6ntORus= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=eHu1wdEj; arc=none smtp.client-ip=95.215.58.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="eHu1wdEj" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1757090369; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=iOaansnqrfJ2qIoO8NuHxuhSuAO+KjcupJ31HyXxFew=; b=eHu1wdEjUCNeh0xR5nQQn/EBygQTazqTQWce1dBrHyAYLYNUgtoGBaCVbJaZQroUEFpIyR yOm/NXS6pd5dxVB7IrDus6jjB7buLLbkaT4bEMxFIOt396653SCTI3maTARvz7BgHfX/// y3cGJGyoEKElpyCy9hqrL+Jd4QRw9xA= From: Thorsten Blum To: Giovanni Cabiddu , Herbert Xu , "David S. Miller" , Peter Zijlstra , Greg KH Cc: Thorsten Blum , qat-linux@intel.com, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] crypto: qat - Replace kzalloc() + copy_from_user() with memdup_user() Date: Fri, 5 Sep 2025 18:39:11 +0200 Message-ID: <20250905163915.523396-1-thorsten.blum@linux.dev> Precedence: bulk X-Mailing-List: linux-crypto@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT Replace kzalloc() followed by copy_from_user() with memdup_user() to improve and simplify adf_ctl_alloc_resources(). memdup_user() returns either -ENOMEM or -EFAULT (instead of -EIO) if an error occurs. Remove the unnecessary device id initialization, since memdup_user() (like copy_from_user()) immediately overwrites it. No functional changes intended other than returning the more idiomatic error code -EFAULT. Signed-off-by: Thorsten Blum --- drivers/crypto/intel/qat/qat_common/adf_ctl_drv.c | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/drivers/crypto/intel/qat/qat_common/adf_ctl_drv.c b/drivers/crypto/intel/qat/qat_common/adf_ctl_drv.c index 48c62a14a6a7..84bc89e16742 100644 --- a/drivers/crypto/intel/qat/qat_common/adf_ctl_drv.c +++ b/drivers/crypto/intel/qat/qat_common/adf_ctl_drv.c @@ -94,17 +94,10 @@ static int adf_ctl_alloc_resources(struct adf_user_cfg_ctl_data **ctl_data, { struct adf_user_cfg_ctl_data *cfg_data; - cfg_data = kzalloc(sizeof(*cfg_data), GFP_KERNEL); - if (!cfg_data) - return -ENOMEM; - - /* Initialize device id to NO DEVICE as 0 is a valid device id */ - cfg_data->device_id = ADF_CFG_NO_DEVICE; - - if (copy_from_user(cfg_data, (void __user *)arg, sizeof(*cfg_data))) { + cfg_data = memdup_user((void __user *)arg, sizeof(*cfg_data)); + if (IS_ERR(cfg_data)) { pr_err("QAT: failed to copy from user cfg_data.\n"); - kfree(cfg_data); - return -EIO; + return PTR_ERR(cfg_data); } *ctl_data = cfg_data; -- 2.51.0