From: Eric Biggers <ebiggers@kernel.org>
To: linux-cifs@vger.kernel.org, Namjae Jeon <linkinjeon@kernel.org>,
Steve French <smfrench@gmail.com>
Cc: Sergey Senozhatsky <senozhatsky@chromium.org>,
Tom Talpey <tom@talpey.com>,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
Eric Biggers <ebiggers@kernel.org>
Subject: [PATCH 0/3] ksmbd: More crypto library conversions
Date: Tue, 14 Oct 2025 16:17:56 -0700 [thread overview]
Message-ID: <20251014231759.136630-1-ebiggers@kernel.org> (raw)
This series converts fs/smb/server/ to access SHA-512, HMAC-SHA256, and
HMAC-MD5 using the library APIs instead of crypto_shash.
This simplifies the code significantly. It also slightly improves
performance, as it eliminates unnecessary overhead. I haven't done
server-specific benchmarks, but you can get an idea of what to expect by
looking at the numbers I gave for the similar client-side series:
https://lore.kernel.org/linux-cifs/20251014034230.GC2763@sol/
No change in behavior intended. All the crypto computations should be
the same as before. I haven't tested this series (I did test the
similar client-side series), but everything should still work.
Eric Biggers (3):
ksmbd: Use SHA-512 library for SMB3.1.1 preauth hash
ksmbd: Use HMAC-SHA256 library for message signing and key generation
ksmbd: Use HMAC-MD5 library for NTLMv2
fs/smb/server/Kconfig | 6 +-
fs/smb/server/auth.c | 390 +++++++------------------------------
fs/smb/server/auth.h | 10 +-
fs/smb/server/crypto_ctx.c | 24 ---
fs/smb/server/crypto_ctx.h | 15 +-
fs/smb/server/server.c | 4 -
fs/smb/server/smb2pdu.c | 26 +--
fs/smb/server/smb_common.h | 2 +-
8 files changed, 87 insertions(+), 390 deletions(-)
base-commit: 3a8660878839faadb4f1a6dd72c3179c1df56787
--
2.51.0
next reply other threads:[~2025-10-14 23:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-14 23:17 Eric Biggers [this message]
2025-10-14 23:17 ` [PATCH 1/3] ksmbd: Use SHA-512 library for SMB3.1.1 preauth hash Eric Biggers
2025-10-14 23:17 ` [PATCH 2/3] ksmbd: Use HMAC-SHA256 library for message signing and key generation Eric Biggers
2025-10-16 5:00 ` Namjae Jeon
2025-10-16 17:54 ` Eric Biggers
2025-10-14 23:17 ` [PATCH 3/3] ksmbd: Use HMAC-MD5 library for NTLMv2 Eric Biggers
2025-10-16 5:03 ` [PATCH 0/3] ksmbd: More crypto library conversions Namjae Jeon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251014231759.136630-1-ebiggers@kernel.org \
--to=ebiggers@kernel.org \
--cc=linkinjeon@kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=senozhatsky@chromium.org \
--cc=smfrench@gmail.com \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).