From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-171.mta0.migadu.com (out-171.mta0.migadu.com [91.218.175.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 01E33314D15 for ; Thu, 23 Oct 2025 14:33:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761230010; cv=none; b=s0G+UjTdPopIuzJ0UBq0v1Mm+2c54crv3cMKTjrBmxP3uaLw9GlCyxMQZG0PL70tLhcYHXSjSYqxw5AHbGct2sjeVhXyAeI8YrlSSAzyGjHM7/zKrhf8RwGNLMo7esou2T68DfMVJzCTwhyOOZcRmpKaoCW8pOoqY08zvqpsiwU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761230010; c=relaxed/simple; bh=8NgwQweyZuDJ8/KcYC5Hfn23aZHcjwuD1uknqfrLQwc=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=H5TnHDoiGb4oDZKZY54l0aK8G3djEavPn3oantTtspbHXocxjvF8Aw7EhcNZb48sGgfG9/7VNzZiWQAqgPxL/x6CSOc3MClRjNlrHPbhi+mp4vBW2wNvilGyEYKmhtKLoK1PwSqVOvzjfFWWh/IB++XCvGbXeVms1O1wJWlDDJI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=LQOOn0pK; arc=none smtp.client-ip=91.218.175.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="LQOOn0pK" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1761229995; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=15GFw2QBhjZqG65uQkH32rydnUNCMz9Y1CRyt3oylXs=; b=LQOOn0pKCqvLAPAzE+RHedfGPfEU3lyrAoKa+Sq8XPCKClSqq1mOIu/Go7Y869h5sqvzdN PQznvWadajfcl4ZWgbr2QTXLDNjPuXSvDxN+MYdh8yhh856/QSQDvlVTpDOFMKU2ttMmo/ Sm3qrtubDAv5qdkutncbFTJi9qjEjzc= From: Thorsten Blum To: David Howells , Lukas Wunner , Ignat Korchagin , Herbert Xu , "David S. Miller" Cc: Thorsten Blum , keyrings@vger.kernel.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/2] keys: Remove unnecessary local variable from ca_keys_setup Date: Thu, 23 Oct 2025 16:32:31 +0200 Message-ID: <20251023143231.2086-2-thorsten.blum@linux.dev> Precedence: bulk X-Mailing-List: linux-crypto@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT The variable 'ret', whose name implies a return variable, is only used to temporarily store the result of __asymmetric_key_hex_to_key_id(). Use the result directly and remove the local variable. Signed-off-by: Thorsten Blum --- crypto/asymmetric_keys/restrict.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/crypto/asymmetric_keys/restrict.c b/crypto/asymmetric_keys/restrict.c index afcd4d101ac5..57ee2021fef7 100644 --- a/crypto/asymmetric_keys/restrict.c +++ b/crypto/asymmetric_keys/restrict.c @@ -29,15 +29,13 @@ static int __init ca_keys_setup(char *str) if (strncmp(str, "id:", 3) == 0) { struct asymmetric_key_id *p = &cakey.id; size_t hexlen = (strlen(str) - 3) / 2; - int ret; if (hexlen == 0 || hexlen > sizeof(cakey.data)) { pr_err("Missing or invalid ca_keys id\n"); return 1; } - ret = __asymmetric_key_hex_to_key_id(str + 3, p, hexlen); - if (ret < 0) + if (__asymmetric_key_hex_to_key_id(str + 3, p, hexlen) < 0) pr_err("Unparsable ca_keys id hex string\n"); else ca_keyid = p; /* owner key 'id:xxxxxx' */ -- 2.51.0