[PATCH] crypto: tcrypt - Remove unused poly1305 support

[PATCH] crypto: tcrypt - Remove unused poly1305 support

[Eric Biggers]

Since the crypto_shash support for poly1305 was removed, the tcrypt
support for it is now unused as well.  Support for benchmarking the
kernel's Poly1305 code is now provided by the poly1305 kunit test.

Signed-off-by: Eric Biggers <ebiggers@kernel.org>
---

This patch is targeting cryptodev/master

 crypto/tcrypt.c |  4 ----
 crypto/tcrypt.h | 18 ------------------
 2 files changed, 22 deletions(-)

diff --git a/crypto/tcrypt.c b/crypto/tcrypt.c
index d1d88debbd71..3baff6bfb9d1 100644
--- a/crypto/tcrypt.c
+++ b/crypto/tcrypt.c
@@ -2266,14 +2266,10 @@ static int do_test(const char *alg, u32 type, u32 mask, int m, u32 num_mb)
 		fallthrough;
 	case 319:
 		test_hash_speed("crc32c", sec, generic_hash_speed_template);
 		if (mode > 300 && mode < 400) break;
 		fallthrough;
-	case 321:
-		test_hash_speed("poly1305", sec, poly1305_speed_template);
-		if (mode > 300 && mode < 400) break;
-		fallthrough;
 	case 322:
 		test_hash_speed("sha3-224", sec, generic_hash_speed_template);
 		if (mode > 300 && mode < 400) break;
 		fallthrough;
 	case 323:
diff --git a/crypto/tcrypt.h b/crypto/tcrypt.h
index 7f938ac93e58..85c3f77bcfb4 100644
--- a/crypto/tcrypt.h
+++ b/crypto/tcrypt.h
@@ -94,24 +94,6 @@ static struct hash_speed generic_hash_speed_template[] = {
 
 	/* End marker */
 	{  .blen = 0,	.plen = 0, }
 };
 
-static struct hash_speed poly1305_speed_template[] = {
-	{ .blen = 96,	.plen = 16, },
-	{ .blen = 96,	.plen = 32, },
-	{ .blen = 96,	.plen = 96, },
-	{ .blen = 288,	.plen = 16, },
-	{ .blen = 288,	.plen = 32, },
-	{ .blen = 288,	.plen = 288, },
-	{ .blen = 1056,	.plen = 32, },
-	{ .blen = 1056,	.plen = 1056, },
-	{ .blen = 2080,	.plen = 32, },
-	{ .blen = 2080,	.plen = 2080, },
-	{ .blen = 4128,	.plen = 4128, },
-	{ .blen = 8224,	.plen = 8224, },
-
-	/* End marker */
-	{  .blen = 0,	.plen = 0, }
-};
-
 #endif	/* _CRYPTO_TCRYPT_H */

base-commit: d633730bb3873578a00fde4b97f9ac62a1be8d34
-- 
2.51.2

Re: [PATCH] crypto: tcrypt - Remove unused poly1305 support

[Ard Biesheuvel]

On Fri, 14 Nov 2025 at 04:05, Eric Biggers <ebiggers@kernel.org> wrote:
>
> Since the crypto_shash support for poly1305 was removed, the tcrypt
> support for it is now unused as well.  Support for benchmarking the
> kernel's Poly1305 code is now provided by the poly1305 kunit test.
>
> Signed-off-by: Eric Biggers <ebiggers@kernel.org>

Acked-by: Ard Biesheuvel <ardb@kernel.org>

> ---
>
> This patch is targeting cryptodev/master
>
>  crypto/tcrypt.c |  4 ----
>  crypto/tcrypt.h | 18 ------------------
>  2 files changed, 22 deletions(-)
>
> diff --git a/crypto/tcrypt.c b/crypto/tcrypt.c
> index d1d88debbd71..3baff6bfb9d1 100644
> --- a/crypto/tcrypt.c
> +++ b/crypto/tcrypt.c
> @@ -2266,14 +2266,10 @@ static int do_test(const char *alg, u32 type, u32 mask, int m, u32 num_mb)
>                 fallthrough;
>         case 319:
>                 test_hash_speed("crc32c", sec, generic_hash_speed_template);
>                 if (mode > 300 && mode < 400) break;
>                 fallthrough;
> -       case 321:
> -               test_hash_speed("poly1305", sec, poly1305_speed_template);
> -               if (mode > 300 && mode < 400) break;
> -               fallthrough;
>         case 322:
>                 test_hash_speed("sha3-224", sec, generic_hash_speed_template);
>                 if (mode > 300 && mode < 400) break;
>                 fallthrough;
>         case 323:
> diff --git a/crypto/tcrypt.h b/crypto/tcrypt.h
> index 7f938ac93e58..85c3f77bcfb4 100644
> --- a/crypto/tcrypt.h
> +++ b/crypto/tcrypt.h
> @@ -94,24 +94,6 @@ static struct hash_speed generic_hash_speed_template[] = {
>
>         /* End marker */
>         {  .blen = 0,   .plen = 0, }
>  };
>
> -static struct hash_speed poly1305_speed_template[] = {
> -       { .blen = 96,   .plen = 16, },
> -       { .blen = 96,   .plen = 32, },
> -       { .blen = 96,   .plen = 96, },
> -       { .blen = 288,  .plen = 16, },
> -       { .blen = 288,  .plen = 32, },
> -       { .blen = 288,  .plen = 288, },
> -       { .blen = 1056, .plen = 32, },
> -       { .blen = 1056, .plen = 1056, },
> -       { .blen = 2080, .plen = 32, },
> -       { .blen = 2080, .plen = 2080, },
> -       { .blen = 4128, .plen = 4128, },
> -       { .blen = 8224, .plen = 8224, },
> -
> -       /* End marker */
> -       {  .blen = 0,   .plen = 0, }
> -};
> -
>  #endif /* _CRYPTO_TCRYPT_H */
>
> base-commit: d633730bb3873578a00fde4b97f9ac62a1be8d34
> --
> 2.51.2
>
>

Re: [PATCH] crypto: tcrypt - Remove unused poly1305 support

[Herbert Xu]

On Thu, Nov 13, 2025 at 07:03:44PM -0800, Eric Biggers wrote:
> Since the crypto_shash support for poly1305 was removed, the tcrypt
> support for it is now unused as well.  Support for benchmarking the
> kernel's Poly1305 code is now provided by the poly1305 kunit test.
> 
> Signed-off-by: Eric Biggers <ebiggers@kernel.org>
> ---
> 
> This patch is targeting cryptodev/master
> 
>  crypto/tcrypt.c |  4 ----
>  crypto/tcrypt.h | 18 ------------------
>  2 files changed, 22 deletions(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt