From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f51.google.com (mail-lf1-f51.google.com [209.85.167.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D6502220F2D for ; Sat, 22 Nov 2025 22:47:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763851677; cv=none; b=LHuMvisEsz3aBFQxzwNZduwlNNjrAv0zfBaGLJc2ENBjD0Rsd5DlI4qxUP4dSX9UQuDhwYNvmKyLquhpGiRRbNzTn2OFteo9QkhZv46FHSPoeXmgcmLHb8zQhGqy3VPfPLpqP6x1ButKhsUTd+nNHod2JXE1qgtgNoxDTIkewR0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763851677; c=relaxed/simple; bh=mDmOqDRRV1GxRTkt03uYnfvm5YBI/u/mWZasnkUTwrI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=eqMx0ATyO9eAgm8yyaWYKa316lAasp9AImXBB5EGKXCeeSXxQf6MQd/UumainAb4Iu9UX76JRovqr0gqQVba13R4uIIw+3Hpi1Qx56uV44yywl+C0spky1Iaggv5yfjMP3t5pmFvqMa16qo6nz4qgTSrgsj0vkqH1KKrL2gyd4s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=m4EYqLjM; arc=none smtp.client-ip=209.85.167.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="m4EYqLjM" Received: by mail-lf1-f51.google.com with SMTP id 2adb3069b0e04-59583505988so4513588e87.1 for ; Sat, 22 Nov 2025 14:47:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763851674; x=1764456474; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=mm9cJVhutkedd51ycbYwKmMqp19QwPFiX/ffFg8rVcg=; b=m4EYqLjMnZAClasW5oW/RKRiG7pn1i/2sd87a2+bGT5arzuzX2s9OWunw3ssNpcdIL Rt3hNDSuFUBrtfbXvhjdipl2gBlBuevvx/2V/Sci3GW099P+W5/rd7vFyuWpyVXP1yQP MK62n9rzpZxAKODtmj7axGjtZm2iPhssZ7V5ietC61jcOyFvK9Nmes+GYZJ0bfVVY9W3 HhsNbNtfDCgWUxgyoFMe3TEbEmFHKPlLJzBCay6GBLVkLziLLWupjzRTYCBTQvVTCNtC PCE0gN7ui5o9znFYb9NWADBrbgacrALeEnX1YBs7J3e4rCG9ErcZLONAjVpKnh7gKzq8 xDnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763851674; x=1764456474; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=mm9cJVhutkedd51ycbYwKmMqp19QwPFiX/ffFg8rVcg=; b=qI1HYMh6dPlrYRHy7hUxy0cwl5geHpUAQxo9HYdVtDnv5QmmclqNu7HsKplYM8+VlP zMIHz8pxkRtAA1HXULoSDDSbD1bWvtcKlO5jXkvVUPjs4K7T8fgasfsWvBr2kTHz99K1 iZakFOruo7bTB0T90ygRtw6TFHqpmre8UYCkxDqebfRzBX8dCBoiQbGl1mq6vS4cffod RWLqOg+/neEdSmzNru5XNmg3/YjZeL/BkDCLCeXLfuVgk+NLLHrcxalm1uYSMqtcA4Bc LBEg9+lDZ+H5gFh/jT1yR2KSGfX6Rt0kkXa8/AFOgaru/2KZRX+QFKmKtJLmgffoxdmL zxQg== X-Forwarded-Encrypted: i=1; AJvYcCUSzzPgWHwDCo/N8kPukrWSLQZ0dqYgkyTRwrId8QkHmr1JimWfXj3sSNMmmGmA+euQXh4kbyzsxjWarVk=@vger.kernel.org X-Gm-Message-State: AOJu0Ywz0d9VpJXttETLSNDNy5vpHaEMQyre12XN8gYj5KIrGO5756UC a7n8qGqPKwlWHSVBS8D+rXP+NQgQTZfIR2Z1pVFzXDDMD6Sl6zHZeqYV X-Gm-Gg: ASbGnct4nLiEYkH7e/wvqs+Yw0cKsf3Ez6gPPcvFwPd6v5/19LD/y8P3/36CyQPzU6s a9ZsBJPRKdxyyzPvAo5PnVYhC8GTp246kYDCZ7EqSEE8Cdnrh9fYKf/kGN1T92JjsdPGz0ZY31b 7dnZs/HT7wFRwZnHDl2pjOtx5AIuVJQeI+wFNe480bfWgpA7P3mbc/OxO1PJhwzRrYzrFZO5m+X AuxkXV/v2gYUhbd+4oREbjcT77Z0CiCaJ/8ihEBZyX/xZROh3mOlcg93hHHiMAXayKBvHHzvGxo FLNshEYyQBTexzOBdgz5LSpVatEuwMfHcENvQcW9UMaTwKwdjEbp6QNKh6RmTC3LZ4cS965wswN LRb1Ix4b9XxzgMTAPLmOXpZqGovyIlvkGlVOEM87LlCXvLUfug8TPxyycwZ291DD4uY049xwW8z jo7HaziU4m2w== X-Google-Smtp-Source: AGHT+IG25dEQnHwaBToxpvBjTeZ/3RB3yCymIb0k9rzfOt31nS8ruDCrSu8IePguUMWt0EMXA9m5xw== X-Received: by 2002:a05:6512:308c:b0:596:a000:596 with SMTP id 2adb3069b0e04-596a0000a2bmr3428587e87.10.1763851673743; Sat, 22 Nov 2025 14:47:53 -0800 (PST) Received: from localhost ([109.167.240.218]) by smtp.gmail.com with UTF8SMTPSA id 2adb3069b0e04-5969dbc5988sm2742367e87.78.2025.11.22.14.47.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 22 Nov 2025 14:47:52 -0800 (PST) From: Askar Safin To: mpatocka@redhat.com Cc: Dell.Client.Kernel@dell.com, agk@redhat.com, brauner@kernel.org, dm-devel@lists.linux.dev, ebiggers@kernel.org, kix@kix.es, linux-block@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-crypto@vger.kernel.org, linux-lvm@lists.linux.dev, linux-mm@kvack.org, linux-pm@vger.kernel.org, linux-raid@vger.kernel.org, lvm-devel@lists.linux.dev, milan@mazyland.cz, msnitzer@redhat.com, mzxreary@0pointer.de, nphamcs@gmail.com, pavel@ucw.cz, rafael@kernel.org, ryncsn@gmail.com, safinaskar@gmail.com, torvalds@linux-foundation.org Subject: Re: [PATCH 1/2] pm-hibernate: flush disk cache when suspending Date: Sun, 23 Nov 2025 01:47:48 +0300 Message-ID: <20251122224748.3724202-1-safinaskar@gmail.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-crypto@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Mikulas Patocka : > [PATCH 1/2] pm-hibernate: flush disk cache when suspending > > There was reported failure that suspend doesn't work with dm-integrity. > The reason for the failure is that the suspend code doesn't issue the > FLUSH bio - the data still sits in the dm-integrity cache and they are > lost when poweroff happens. I tested this patchset (in Qemu). It works. Here is script I used for testing: https://zerobin.net/?66669be7d2404586#xWufhCq7zCoOk3LJcJCj7W4k3vYT3U4vhGutTN3p8m0= Here are logs: https://zerobin.net/?5d4a2abbad751890#WMcQl4FAZC9KqcAuJU3TSVr7wuVnPFwI7dlinA9QHOo= Tested-By: Askar Safin There was no any reason to wait for me. You could easily test using script above. Also: Linux shows this scary message when booting in Qemu: [ 0.512581] sd 0:0:0:0: [sda] Write cache: enabled, read cache: enabled, doesn't support DPO or FUA So, FUA is not supported? Does it mean that this patch is wrong, and works purely by chance? -- Askar Safin