From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 86816311C2E for ; Fri, 28 Nov 2025 11:44:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764330268; cv=none; b=f/ThSnTsPjZq38VwhyYPHzqf/drP5Ds/OYXVMmJgkDJu9yRCu9uTG2WoV1Tim+eJt9sRJdLHNVb9wFLs0zbxbDbeZ9b8ClYflUxN/CVueXQEd8/c6uBDLDchqVA50A4TxUM3H2S+CaIaqdpZCfRHGog1QO2atSmAnT2SCMsD3cQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764330268; c=relaxed/simple; bh=XImptFJap0oPq5WrKW6CqR31kSzqsIuoWmParQCd2Oo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=RLtgGzVrussZn2qhaJzsDerSbPZturf8XtjWBSqK5/8CFyaRQBD0/Hcgg0o+c2bb3KYuDtu4oXx4xvF0i/7ZPEMCJG8eTFM1hEEorTuk5JIWZ+iyZq7DCF0Otx3JTSiLXYb+F8pEm2uYnhty6RH1yq4R75LrJAuZ3p9sIWNoP6A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=ibdT/QXl; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="ibdT/QXl" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-4779cc419b2so17204745e9.3 for ; Fri, 28 Nov 2025 03:44:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1764330263; x=1764935063; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=jJ2RVnJy5oJsAwMm3d/sS5ZIYEn59yzd0SudjeWcx/g=; b=ibdT/QXlMxBOSDhz5pyQpm7OQJxIHMfFgWQRiQn/e+4sr5t3CFy6H2mdp37Ab+48qq eI3vFX0igTKM7mzf4g8amcPht8qpm7EPi3JR02TYL9xQ6tqUwOQHJMmf6dXp5aAKLZ8l rGZoZTBk7UTscRCsj3bGK9MzDuprIFZoLvYuZ1C7lVB2yb7AARZj4P5d6SRsBEyUubIm A1XRGQUFvdfRYigmzU7WaFJMTHI5oOrjD6CSdBVdx1xAlAcgJn3QV0+g4zWeZ7xCBH+6 6tecMLxVkhT3VN9q9CZgDX778GQizHB59DK5S7FyWMcEb2LCVh+hYHcRgGYkJ1yYYFx4 qe1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764330263; x=1764935063; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=jJ2RVnJy5oJsAwMm3d/sS5ZIYEn59yzd0SudjeWcx/g=; b=QrbxTYMP6BGv/F86N0PkNHjV9KCbIkr2fHEwmtXrN86sN85WUtSv+GqpWrRRzMyWgy AcY658894/YG+jlsCDO3NJA2WQQYmf+4kse7Ej/up3b8GMT8sOjjPGHoP/t5q1oAb4NE AQFv1PWM/DHtFxjrsVgm0ui9wae+YWrCTQTvfI+SZiH+HV5sPB06bFI/iV6QVcY37Cfn QX/BGwiHA46yADv8M2/xq13mpGmY3ylFyoM9fualB8Bg2fyFObGkMGalwZ9qUqCdZeON V1bF7TD76PDBP2W0psonI+nSja5y6Zllur328RF7vsTNevN/Mb0echJl5r7rB9qqylXe CiFA== X-Forwarded-Encrypted: i=1; AJvYcCUZmoyYQiqtmVGFlmOq0Kk3rThIzwZ11us+gTphj0sPxaHFEXD3lgZuX5Gg3oNzZ59FpJuyfiCc/VBYT1g=@vger.kernel.org X-Gm-Message-State: AOJu0YyjSEeiogZtLQs/9pjW+mUQK7Qyhcq+OP968D3tooofXqcRNqXd iWAewmCRdMl5MvBUUfOgJQimaDS7W1t37q21T7p09n1RB0miJ3zV2+2h4PSdfV+XAIw= X-Gm-Gg: ASbGncupphTK8m1mt+fCwbc5Bo6ilAiWZTJ/TOSHCL3Dy4OX6iXT104jLowH0Yjvgu1 3gcuARSqiMjs8Qw66cY7nsj73BPsOibew+uQgIh9QdWrZGaUokKGiHk4a78z5imVg2YsPXFqDU5 XsbPfEFxn2gkLekRbFI5AllTVwb4HMp2OGQlgW9FAGfhELpkDbkyPqqMtNFWn3xUOnWAX8Q0wYV CJE3KHuYdWJ7s63nMLrWyGedF5QGUEDaiULbHPEdxPw+UCVlw6okrfaGRkpsOzn5z0eSIkB2v2G lnx3I9sZuJQTYLuidOHdvxTEazaqQi5t97tOwX3Gi/fGN1on75dIR13oFR167LRDs64zVcfqFOP cUgaQrOfCqGNiuCsQHuaS+u3uvXQhiArqZkKFVrfc/PBxKgtCg+pdG19lqXtKDTRI/7QlJGflJa dmVDEUkA== X-Google-Smtp-Source: AGHT+IHhhS4/wCvbANF7Uuf+oLjy3xxv/2rDCPnr+ZbQtZO8GRMgWdt+QrRLr5yvheEx+Y99myaphw== X-Received: by 2002:a05:600c:1547:b0:477:63db:c718 with SMTP id 5b1f17b1804b1-477c114307emr300576425e9.16.1764330262944; Fri, 28 Nov 2025 03:44:22 -0800 (PST) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:f3c6:aa54:79d2:8979]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47906cb1f60sm89888445e9.1.2025.11.28.03.44.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Nov 2025 03:44:22 -0800 (PST) From: Bartosz Golaszewski Date: Fri, 28 Nov 2025 12:44:05 +0100 Subject: [PATCH v9 07/11] crypto: qce - Use existing devres APIs in devm_qce_dma_request() Precedence: bulk X-Mailing-List: linux-crypto@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20251128-qcom-qce-cmd-descr-v9-7-9a5f72b89722@linaro.org> References: <20251128-qcom-qce-cmd-descr-v9-0-9a5f72b89722@linaro.org> In-Reply-To: <20251128-qcom-qce-cmd-descr-v9-0-9a5f72b89722@linaro.org> To: Vinod Koul , Jonathan Corbet , Thara Gopinath , Herbert Xu , "David S. Miller" , Udit Tiwari , Daniel Perez-Zoghbi , Md Sadre Alam , Dmitry Baryshkov Cc: dmaengine@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2130; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=0HNGOpA5BOBppMRD34n6Vlm9z76LKmywM4te9hh3rgw=; b=owEBbQKS/ZANAwAKAQWdLsv/NoTDAcsmYgBpKYsJ6qql8IGnaHnHmPWao/nY0akeTfuJ+1g/v ANx/BW1yo2JAjMEAAEKAB0WIQSR5RMt5bVGHXuiZfwFnS7L/zaEwwUCaSmLCQAKCRAFnS7L/zaE w0LsEACmw5Al7p+VtiKsgT5X28Z0MSlzU52WUmT5dx/6YTDd7dz/8kG8oK/u0E93LHsOTINuET2 YJX5F+mPovkmeV/TdynbCAF24QTr4d7hu5SnA8PJuHiBVOxhjovM49bT+baQfr1QYOjBqdQdIkc ZJP/eTUkNKr9KdjFwHJ+fd4XsRYSDuH+8Ossj95FzBr9feaRqGEvc806STtH3lftApVGRMwKLNF wXx3vQe94hl3JF9Zi8UamBVDmRubXQHtyOUpHqFyvzTDwX34uHfz1AMwxkNj6/jxuEIuitfCTHt UeKgKbUCdzwbDlTUHHuePv3SMmmBedKEl7e2aILqexcQADv8ozki6HJUrLIt4/7CjiI8WtaGMFy bN9uYzma9L/TvgWBbI1NX5a0wo4VygYxhn9mpXbwLsnoKLq2OTbo3E1gjHMoKZoojkh9aGXn6js VJ2rhdkgwxW++u1iy88Jj44VbMEwUZCwCtoYU5cWZQb0n0gFgL5XodxcLR6JAg99P69NQ0nhY8w bLVn8Pxan3DlErnhzZvSW0jDUW5ckhEAs7cZ3pwbjMjJc8YYbdS3Nj//jaNiUNx3JArFodjnLlN ARCN7iyXogCqURuExIR2b/2jh8XcxJe7DOgy1n/QBGtzM7iNPQ3sV4qOAfdI4OtVwke82hidYyH fYnVGVf/T5IPL1Q== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski Switch to devm_kmalloc() and devm_dma_alloc_chan() in devm_qce_dma_request(). This allows us to drop two labels and shrink the function. Signed-off-by: Bartosz Golaszewski --- drivers/crypto/qce/dma.c | 39 +++++++++------------------------------ 1 file changed, 9 insertions(+), 30 deletions(-) diff --git a/drivers/crypto/qce/dma.c b/drivers/crypto/qce/dma.c index c29b0abe9445381a019e0447d30acfd7319d5c1f..a46264735bb895b6199969e83391383ccbbacc5f 100644 --- a/drivers/crypto/qce/dma.c +++ b/drivers/crypto/qce/dma.c @@ -12,47 +12,26 @@ #define QCE_IGNORE_BUF_SZ (2 * QCE_BAM_BURST_SIZE) -static void qce_dma_release(void *data) -{ - struct qce_dma_data *dma = data; - - dma_release_channel(dma->txchan); - dma_release_channel(dma->rxchan); - kfree(dma->result_buf); -} - int devm_qce_dma_request(struct qce_device *qce) { struct qce_dma_data *dma = &qce->dma; struct device *dev = qce->dev; - int ret; - dma->txchan = dma_request_chan(dev, "tx"); + dma->txchan = devm_dma_request_chan(dev, "tx"); if (IS_ERR(dma->txchan)) return dev_err_probe(dev, PTR_ERR(dma->txchan), "Failed to get TX DMA channel\n"); - dma->rxchan = dma_request_chan(dev, "rx"); - if (IS_ERR(dma->rxchan)) { - ret = dev_err_probe(dev, PTR_ERR(dma->rxchan), - "Failed to get RX DMA channel\n"); - goto error_rx; - } + dma->rxchan = devm_dma_request_chan(dev, "rx"); + if (IS_ERR(dma->rxchan)) + return dev_err_probe(dev, PTR_ERR(dma->rxchan), + "Failed to get RX DMA channel\n"); - dma->result_buf = kmalloc(QCE_RESULT_BUF_SZ + QCE_IGNORE_BUF_SZ, - GFP_KERNEL); - if (!dma->result_buf) { - ret = -ENOMEM; - goto error_nomem; - } + dma->result_buf = devm_kmalloc(dev, QCE_RESULT_BUF_SZ + QCE_IGNORE_BUF_SZ, GFP_KERNEL); + if (!dma->result_buf) + return -ENOMEM; - return devm_add_action_or_reset(dev, qce_dma_release, dma); - -error_nomem: - dma_release_channel(dma->rxchan); -error_rx: - dma_release_channel(dma->txchan); - return ret; + return 0; } struct scatterlist * -- 2.51.0