* [PATCH v2] crypto: scompress - Use crypto_unregister_scomps in crypto_register_scomps
@ 2025-12-11 8:52 Thorsten Blum
2025-12-19 7:10 ` Herbert Xu
0 siblings, 1 reply; 2+ messages in thread
From: Thorsten Blum @ 2025-12-11 8:52 UTC (permalink / raw)
To: Herbert Xu, David S. Miller; +Cc: Thorsten Blum, linux-crypto, linux-kernel
Replace the for loop with a call to crypto_unregister_scomps(). Return
'ret' immediately and remove the goto statement to simplify the error
handling code. No functional changes.
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
Changes in v2:
- Leave crypto_unregister_scomps() as is (Herbert)
- Link to v1: https://lore.kernel.org/lkml/20251210132548.569689-2-thorsten.blum@linux.dev/
---
crypto/scompress.c | 12 ++++--------
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/crypto/scompress.c b/crypto/scompress.c
index 1a7ed8ae65b0..8d70c5ec6f8b 100644
--- a/crypto/scompress.c
+++ b/crypto/scompress.c
@@ -383,17 +383,13 @@ int crypto_register_scomps(struct scomp_alg *algs, int count)
for (i = 0; i < count; i++) {
ret = crypto_register_scomp(&algs[i]);
- if (ret)
- goto err;
+ if (ret) {
+ crypto_unregister_scomps(algs, i);
+ return ret;
+ }
}
return 0;
-
-err:
- for (--i; i >= 0; --i)
- crypto_unregister_scomp(&algs[i]);
-
- return ret;
}
EXPORT_SYMBOL_GPL(crypto_register_scomps);
--
Thorsten Blum <thorsten.blum@linux.dev>
GPG: 1D60 735E 8AEF 3BE4 73B6 9D84 7336 78FD 8DFE EAD4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] crypto: scompress - Use crypto_unregister_scomps in crypto_register_scomps
2025-12-11 8:52 [PATCH v2] crypto: scompress - Use crypto_unregister_scomps in crypto_register_scomps Thorsten Blum
@ 2025-12-19 7:10 ` Herbert Xu
0 siblings, 0 replies; 2+ messages in thread
From: Herbert Xu @ 2025-12-19 7:10 UTC (permalink / raw)
To: Thorsten Blum; +Cc: David S. Miller, linux-crypto, linux-kernel
On Thu, Dec 11, 2025 at 09:52:51AM +0100, Thorsten Blum wrote:
> Replace the for loop with a call to crypto_unregister_scomps(). Return
> 'ret' immediately and remove the goto statement to simplify the error
> handling code. No functional changes.
>
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
> ---
> Changes in v2:
> - Leave crypto_unregister_scomps() as is (Herbert)
> - Link to v1: https://lore.kernel.org/lkml/20251210132548.569689-2-thorsten.blum@linux.dev/
> ---
> crypto/scompress.c | 12 ++++--------
> 1 file changed, 4 insertions(+), 8 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-12-19 7:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-12-11 8:52 [PATCH v2] crypto: scompress - Use crypto_unregister_scomps in crypto_register_scomps Thorsten Blum
2025-12-19 7:10 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).