From: Eric Biggers <ebiggers@kernel.org>
To: Li Tian <litian@redhat.com>
Cc: linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S . Miller" <davem@davemloft.net>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
Simo Sorce <ssorce@redhat.com>
Subject: Re: [PATCH RFC] crypto/hkdf: Skip tests with keys too short in FIPS mode
Date: Tue, 16 Dec 2025 20:13:07 -0800 [thread overview]
Message-ID: <20251217041307.GB3424@sol> (raw)
In-Reply-To: <CAHhBTWuXQY5CBLTT+-+WsTDw6Pua=Kt-4Mrj6+qiEjKEi+SSSQ@mail.gmail.com>
On Wed, Dec 17, 2025 at 08:08:48AM +0800, Li Tian wrote:
> On Wed, Dec 10, 2025 at 6:54 AM Eric Biggers <ebiggers@kernel.org> wrote:
> > What problem are you trying to solve?
>
> Eric, as you've said "keylen < 14 check in the new version in
> crypto/sha256.c." was forgotten.
> IMHO, it deserves recovery in terms of FIPS. And by the time the check
> is restored, the hkdf_test
> cases failure will likely surface again. Hence the skipping in this proposal.
>
> Li Tian
Sure, but there's no reason to consider this patch unless the incorrect
and problematic keylen check is added back in.
- Eric
prev parent reply other threads:[~2025-12-17 4:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-05 11:31 [PATCH RFC] crypto/hkdf: Skip tests with keys too short in FIPS mode Li Tian
2025-12-09 22:54 ` Eric Biggers
2025-12-17 0:08 ` Li Tian
2025-12-17 4:13 ` Eric Biggers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251217041307.GB3424@sol \
--to=ebiggers@kernel.org \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=litian@redhat.com \
--cc=ssorce@redhat.com \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).