* [PATCH] crypto: stm32 - Remove unnecessary checks before calling memcpy
@ 2026-01-09 14:20 Thorsten Blum
2026-01-31 2:48 ` Herbert Xu
0 siblings, 1 reply; 2+ messages in thread
From: Thorsten Blum @ 2026-01-09 14:20 UTC (permalink / raw)
To: Herbert Xu, David S. Miller, Maxime Coquelin, Alexandre Torgue,
Sakari Ailus
Cc: Thorsten Blum, linux-crypto, linux-stm32, linux-arm-kernel,
linux-kernel
memcpy() can be safely called with size 0, which is a no-op. Remove the
unnecessary checks before calling memcpy().
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
drivers/crypto/stm32/stm32-hash.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/crypto/stm32/stm32-hash.c b/drivers/crypto/stm32/stm32-hash.c
index a4436728b0db..d60147a7594e 100644
--- a/drivers/crypto/stm32/stm32-hash.c
+++ b/drivers/crypto/stm32/stm32-hash.c
@@ -1115,8 +1115,7 @@ static int stm32_hash_copy_sgs(struct stm32_hash_request_ctx *rctx,
return -ENOMEM;
}
- if (state->bufcnt)
- memcpy(buf, rctx->hdev->xmit_buf, state->bufcnt);
+ memcpy(buf, rctx->hdev->xmit_buf, state->bufcnt);
scatterwalk_map_and_copy(buf + state->bufcnt, sg, rctx->offset,
min(new_len, rctx->total) - state->bufcnt, 0);
@@ -1300,8 +1299,7 @@ static int stm32_hash_prepare_request(struct ahash_request *req)
}
/* copy buffer in a temporary one that is used for sg alignment */
- if (state->bufcnt)
- memcpy(hdev->xmit_buf, state->buffer, state->bufcnt);
+ memcpy(hdev->xmit_buf, state->buffer, state->bufcnt);
ret = stm32_hash_align_sgs(req->src, nbytes, bs, init, final, rctx);
if (ret)
--
Thorsten Blum <thorsten.blum@linux.dev>
GPG: 1D60 735E 8AEF 3BE4 73B6 9D84 7336 78FD 8DFE EAD4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] crypto: stm32 - Remove unnecessary checks before calling memcpy
2026-01-09 14:20 [PATCH] crypto: stm32 - Remove unnecessary checks before calling memcpy Thorsten Blum
@ 2026-01-31 2:48 ` Herbert Xu
0 siblings, 0 replies; 2+ messages in thread
From: Herbert Xu @ 2026-01-31 2:48 UTC (permalink / raw)
To: Thorsten Blum
Cc: David S. Miller, Maxime Coquelin, Alexandre Torgue, Sakari Ailus,
linux-crypto, linux-stm32, linux-arm-kernel, linux-kernel
On Fri, Jan 09, 2026 at 03:20:36PM +0100, Thorsten Blum wrote:
> memcpy() can be safely called with size 0, which is a no-op. Remove the
> unnecessary checks before calling memcpy().
>
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
> ---
> drivers/crypto/stm32/stm32-hash.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-01-31 2:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-09 14:20 [PATCH] crypto: stm32 - Remove unnecessary checks before calling memcpy Thorsten Blum
2026-01-31 2:48 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox