From: "Mario Limonciello (AMD)" <superm1@kernel.org>
To: "Tom Lendacky" <thomas.lendacky@amd.com>,
"Herbert Xu" <herbert@gondor.apana.org.au>,
"Shyam Sundar S K" <Shyam-sundar.S-k@amd.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Rijo Thomas" <Rijo-john.Thomas@amd.com>
Cc: John Allen <john.allen@amd.com>,
"David S . Miller" <davem@davemloft.net>,
Hans de Goede <hansg@kernel.org>,
linux-crypto@vger.kernel.org (open list:AMD CRYPTOGRAPHIC
COPROCESSOR (CCP) DRIVER),
platform-driver-x86@vger.kernel.org (open list:AMD PMF DRIVER),
Lars Francke <lars.francke@gmail.com>,
Yijun Shen <Yijun.Shen@dell.com>,
Devaraj Rangasamy <Devaraj.Rangasamy@amd.com>,
"Mario Limonciello (AMD)" <superm1@kernel.org>
Subject: [PATCH v5 0/5] Fixes for PMF and CCP drivers after S4
Date: Sun, 11 Jan 2026 23:36:05 -0600 [thread overview]
Message-ID: <20260112053610.2566943-1-superm1@kernel.org> (raw)
Lars Francke reported that the PMF driver fails to work afer S4 with:
ccp 0000:c3:00.2: tee: command 0x5 timed out, disabling PSP
This is because there is a TA loaded to the TEE environment that
is lost during S4. The TEE rings need to be reinitialized and the
TA needs to be reloaded.
This series adds those flows to the PMF and CCP drivers.
v4->v5:
* Fix error return value in psp_restore()
* Fix retry loop in tee_init_ring()
Mario Limonciello (AMD) (4):
crypto: ccp - Declare PSP dead if PSP_CMD_TEE_RING_INIT fails
crypto: ccp - Add an S4 restore flow
crypto: ccp - Factor out ring destroy handling to a helper
crypto: ccp - Send PSP_CMD_TEE_RING_DESTROY when PSP_CMD_TEE_RING_INIT
fails
Shyam Sundar S K (1):
platform/x86/amd/pmf: Prevent TEE errors after hibernate
drivers/crypto/ccp/psp-dev.c | 11 +++++
drivers/crypto/ccp/sp-dev.h | 2 +
drivers/crypto/ccp/sp-pci.c | 24 ++++++++++-
drivers/crypto/ccp/tee-dev.c | 56 ++++++++++++++++++------
drivers/crypto/ccp/tee-dev.h | 1 +
drivers/platform/x86/amd/pmf/core.c | 62 ++++++++++++++++++++++++++-
drivers/platform/x86/amd/pmf/pmf.h | 10 +++++
drivers/platform/x86/amd/pmf/tee-if.c | 12 ++----
include/linux/psp.h | 1 +
9 files changed, 156 insertions(+), 23 deletions(-)
--
2.43.0
next reply other threads:[~2026-01-12 5:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-12 5:36 Mario Limonciello (AMD) [this message]
2026-01-12 5:36 ` [PATCH v5 1/5] platform/x86/amd/pmf: Prevent TEE errors after hibernate Mario Limonciello (AMD)
2026-01-12 5:36 ` [PATCH v5 2/5] crypto: ccp - Declare PSP dead if PSP_CMD_TEE_RING_INIT fails Mario Limonciello (AMD)
2026-01-12 5:36 ` [PATCH v5 3/5] crypto: ccp - Add an S4 restore flow Mario Limonciello (AMD)
2026-01-12 16:33 ` Tom Lendacky
2026-01-12 21:25 ` Mario Limonciello
2026-01-12 22:06 ` Tom Lendacky
2026-01-12 5:36 ` [PATCH v5 4/5] crypto: ccp - Factor out ring destroy handling to a helper Mario Limonciello (AMD)
2026-01-12 5:36 ` [PATCH v5 5/5] crypto: ccp - Send PSP_CMD_TEE_RING_DESTROY when PSP_CMD_TEE_RING_INIT fails Mario Limonciello (AMD)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260112053610.2566943-1-superm1@kernel.org \
--to=superm1@kernel.org \
--cc=Devaraj.Rangasamy@amd.com \
--cc=Rijo-john.Thomas@amd.com \
--cc=Shyam-sundar.S-k@amd.com \
--cc=Yijun.Shen@dell.com \
--cc=davem@davemloft.net \
--cc=hansg@kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=john.allen@amd.com \
--cc=lars.francke@gmail.com \
--cc=linux-crypto@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=thomas.lendacky@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox