* [PATCH] crypto: rng - Use unregister_rngs in register_rngs
@ 2026-01-26 17:50 Thorsten Blum
2026-02-06 10:58 ` Herbert Xu
0 siblings, 1 reply; 2+ messages in thread
From: Thorsten Blum @ 2026-01-26 17:50 UTC (permalink / raw)
To: Neil Horman, Herbert Xu, David S. Miller
Cc: Thorsten Blum, linux-crypto, linux-kernel
Replace the for loop with a call to crypto_unregister_rngs(). Return
'ret' immediately and remove the goto statement to simplify the error
handling code. No functional changes.
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
---
crypto/rng.c | 12 ++++--------
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/crypto/rng.c b/crypto/rng.c
index ee1768c5a400..475b6a42d826 100644
--- a/crypto/rng.c
+++ b/crypto/rng.c
@@ -203,17 +203,13 @@ int crypto_register_rngs(struct rng_alg *algs, int count)
for (i = 0; i < count; i++) {
ret = crypto_register_rng(algs + i);
- if (ret)
- goto err;
+ if (ret) {
+ crypto_unregister_rngs(algs, i);
+ return ret;
+ }
}
return 0;
-
-err:
- for (--i; i >= 0; --i)
- crypto_unregister_rng(algs + i);
-
- return ret;
}
EXPORT_SYMBOL_GPL(crypto_register_rngs);
--
Thorsten Blum <thorsten.blum@linux.dev>
GPG: 1D60 735E 8AEF 3BE4 73B6 9D84 7336 78FD 8DFE EAD4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] crypto: rng - Use unregister_rngs in register_rngs
2026-01-26 17:50 [PATCH] crypto: rng - Use unregister_rngs in register_rngs Thorsten Blum
@ 2026-02-06 10:58 ` Herbert Xu
0 siblings, 0 replies; 2+ messages in thread
From: Herbert Xu @ 2026-02-06 10:58 UTC (permalink / raw)
To: Thorsten Blum; +Cc: Neil Horman, David S. Miller, linux-crypto, linux-kernel
On Mon, Jan 26, 2026 at 06:50:18PM +0100, Thorsten Blum wrote:
> Replace the for loop with a call to crypto_unregister_rngs(). Return
> 'ret' immediately and remove the goto statement to simplify the error
> handling code. No functional changes.
>
> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
> ---
> crypto/rng.c | 12 ++++--------
> 1 file changed, 4 insertions(+), 8 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-02-06 10:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-26 17:50 [PATCH] crypto: rng - Use unregister_rngs in register_rngs Thorsten Blum
2026-02-06 10:58 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox